Create search-input component #15664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (8)
|
flexsurfer
approved these changes
Apr 17, 2023
|
|
||
| (defn handle-backspace | ||
| [^js/Object event scroll-view-ref] | ||
| (when (= (oops/oget event "nativeEvent.key") "Backspace") |
There was a problem hiding this comment.
just wondering if there are constants for keys
There was a problem hiding this comment.
Not yet, do you find it useful? I could create it if needed.
ATM, I think we can just use strings until they get more common
ilmotta
approved these changes
Apr 17, 2023
FYI @ulisesmac, I've logged this issue last week here #15606. |
ulisesmac
force-pushed
the
15480-new-search-input-component
branch
from
c863c28
to
4e95639
Compare
|
Merged without e2e tests since this adds a new component only available in preview screens |
alwx
pushed a commit
that referenced
this pull request
Apr 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #15480
Summary
This PR implements the new search input component
This component was intended to be used in the recovery seed phrase onboarding screen, but designs have changed and now the component is different (the related issue is #15663), so this PR only adds the component and uses it in its preview screen.
Review notes
The clear icon is not displayed correctly yet.
Platforms
Steps to test
-Navigate to Quo2 preview -> inputs -> seach input
status: ready