Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix jump-to in the community screen is navigating to home screen instead of shell #15647

Merged
merged 1 commit into from
Apr 14, 2023
Merged

fix jump-to in the community screen is navigating to home screen instead of shell #15647

merged 1 commit into from
Apr 14, 2023

Conversation

Parveshdhull
Copy link
Member

fixes #15646

status: ready

@Parveshdhull Parveshdhull self-assigned this Apr 13, 2023
ibrkhalil
ibrkhalil approved these changes Apr 13, 2023
View reviewed changes
Copy link
Contributor

@ibrkhalil ibrkhalil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@status-im-auto
Copy link
Member

status-im-auto commented Apr 13, 2023 •
edited
Loading

Jenkins Builds

❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 4ca90c2 #1 2023-04-13 17:45:41 ~5 min android-e2e 🤖apk 📲
✔️ 4ca90c2 #1 2023-04-13 17:46:06 ~6 min tests 📄log
✔️ 4ca90c2 #1 2023-04-13 17:46:13 ~6 min android 🤖apk 📲
✔️ 4ca90c2 #1 2023-04-13 17:50:28 ~10 min ios 📱ipa 📲
✔️ b482f47 #2 2023-04-14 07:27:35 ~5 min android-e2e 🤖apk 📲
✔️ b482f47 #2 2023-04-14 07:28:19 ~6 min android 🤖apk 📲
✔️ b482f47 #2 2023-04-14 07:28:31 ~6 min tests 📄log
✔️ b482f47 #2 2023-04-14 07:28:53 ~6 min ios 📱ipa 📲

@status-im-auto
Copy link
Member

93% of end-end tests have passed

Total executed tests: 29
Failed tests: 2
Passed tests: 27

IDs of failed tests: 702850,702838

Failed tests (2)

Click to expand
  • Rerun failed tests

    • Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_decline, id: 702850

    Device 2: Find `Button` by `accessibility id`: `tab-recent`
    Device 2: Tap on found: Button 

    medium/test_activity_center.py:142: in test_activity_center_contact_request_decline
    self.errors.verify_no_errors()
base_test_case.py:184: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Username is not shown on 'Add contact' page after entering valid public key

    [[Blocked by 15500]]

    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_message_send_check_timestamps_sender_username, id: 702838

    Device 2: Verifying that 'hello' is under today
    Device 2: Looking for a message by text: hello 

    critical/test_public_chat_browsing.py:418: in test_community_message_send_check_timestamps_sender_username
    channel.verify_message_is_under_today_text(message, self.errors)
../views/chat_view.py:923: in verify_message_is_under_today_text
    message_element.wait_for_visibility_of_element()
../views/base_element.py:135: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: ChatElementByText by xpath:`//*[starts-with(@text,'hello')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen after wait_for_visibility_of_element

    [[blocked by 14797]]

    Device sessions

    Passed tests (27)

    Click to expand

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732
    Device sessions

    2. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    3. test_group_chat_offline_pn, id: 702808
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    2. test_1_1_chat_edit_message, id: 702855
    Device sessions

    3. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    4. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    5. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    6. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    7. test_1_1_chat_pin_messages, id: 702731
    Device sessions

    8. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    9. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    2. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    3. test_community_mentions_push_notification, id: 702786
    Device sessions

    4. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    5. test_community_leave, id: 702845
    Device sessions

    6. test_community_unread_messages_badge, id: 702841
    Device sessions

    7. test_community_message_delete, id: 702839
    Device sessions

    8. test_community_message_edit, id: 702843
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    2. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    2. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    3. test_navigation_jump_to, id: 702936
    Device sessions

    4. test_activity_center_mentions, id: 702957
    Device sessions

    @VolodLytvynenko VolodLytvynenko self-assigned this Apr 14, 2023
    @VolodLytvynenko
    Copy link
    Contributor

    Hi @Parveshdhull. Thank you for PR. Tested and ready to be merged

    @Parveshdhull Parveshdhull force-pushed the fix/shell-community-jump-to-navigation branch from 4ca90c2 to b482f47 Compare April 14, 2023 07:21
    @Parveshdhull Parveshdhull merged commit f6d74df into develop Apr 14, 2023
    @Parveshdhull Parveshdhull deleted the fix/shell-community-jump-to-navigation branch April 14, 2023 07:50
    alwx pushed a commit that referenced this pull request Apr 28, 2023
    @Parveshdhull @alwx
    fix pressing jump-to in the community screen is navigating to home sc…
    0060956 
    …reen instead of shell (#15647)
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @J-Son89 J-Son89 J-Son89 approved these changes

    @ibrkhalil ibrkhalil ibrkhalil approved these changes

    Assignees

    @Parveshdhull Parveshdhull

    @VolodLytvynenko VolodLytvynenko

    Labels
    request-manual-qa Tested - OK
    Projects
    No open projects
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    Quickly pressing jump-to in the community screen is navigating to home screen instead of shell
    5 participants
    @Parveshdhull @status-im-auto @VolodLytvynenko @J-Son89 @ibrkhalil