Jc/add channel list item #14040

J-Son89 · 2022-09-19T23:10:34Z

Implements: #14016

see the designs here:
https://www.figma.com/file/WQZcp6S0EnzxdTL4taoKDv/Mobile-Components?node-id=411%3A18564

ios & android:

Steps to test

Open quo2 library

J-Son89 · 2022-09-19T23:11:08Z

src/quo2/components/avatars/channel_avatar.cljs

@@ -40,6 +40,6 @@
          {:color           (if dark?
                              colors/neutral-40
                              colors/neutral-50)
-           :container-style {:width  16
-                             :height 16}
+           :container-style {:width  12


this lock icon was not matching the Figma designs correctly so I adjusted for both sizes and it now seems correct.

src/quo2/foundations/colors.cljs

status-im-auto · 2022-09-19T23:12:44Z

Jenkins Builds

Click to see older builds (19)

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`ba08e3d`	#1	2022-09-19 23:12:43	~1 min	`tests`	📦`log`
✔️	`ba08e3d`	#1	2022-09-19 23:18:32	~7 min	`android-e2e`	📦`apk` 📲
✔️	`ba08e3d`	#1	2022-09-19 23:20:03	~9 min	`android`	📦`apk` 📲
✔️	`ba08e3d`	#1	2022-09-19 23:25:11	~14 min	`ios`	📦`ipa` 📲

✔️	`2887049`	#2	2022-09-20 12:06:04	~1 min	`tests`	📦`log`
✔️	`2887049`	#2	2022-09-20 12:11:54	~7 min	`android`	📦`apk` 📲
✔️	`2887049`	#2	2022-09-20 12:11:55	~7 min	`android-e2e`	📦`apk` 📲
✔️	`2887049`	#2	2022-09-20 12:16:53	~12 min	`ios`	📦`ipa` 📲

✔️	`a384f60`	#3	2022-09-21 10:25:17	~2 min	`tests`	📦`log`
✔️	`a384f60`	#3	2022-09-21 10:30:53	~7 min	`android-e2e`	📦`apk` 📲
✔️	`a384f60`	#3	2022-09-21 10:31:51	~8 min	`android`	📦`apk` 📲
✔️	`a384f60`	#3	2022-09-21 10:35:55	~12 min	`ios`	📦`ipa` 📲

✔️	`95cb2ca`	#4	2022-09-22 11:09:27	~1 min	`tests`	📦`log`
✔️	`95cb2ca`	#4	2022-09-22 11:15:51	~8 min	`android-e2e`	📦`apk` 📲
✔️	`95cb2ca`	#4	2022-09-22 11:15:54	~8 min	`android`	📦`apk` 📲
✔️	`95cb2ca`	#4	2022-09-22 11:22:52	~15 min	`ios`	📦`ipa` 📲

✔️	`35eb9b1`	#5	2022-09-23 12:08:56	~1 hr 1 min	`tests`	📦`log`
✔️	`35eb9b1`	#5	2022-09-23 12:14:20	~1 hr 7 min	`android-e2e`	📦`apk` 📲
✔️	`35eb9b1`	#5	2022-09-23 12:16:50	~1 hr 9 min	`android`	📦`apk` 📲

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`abcf097`	#6	2022-09-23 13:13:17	~1 min	`tests`	📦`log`
✔️	`abcf097`	#6	2022-09-23 13:18:41	~7 min	`android-e2e`	📦`apk` 📲
✔️	`abcf097`	#6	2022-09-23 13:18:57	~7 min	`android`	📦`apk` 📲
✔️	`abcf097`	#6	2022-09-23 14:10:21	~58 min	`ios`	📦`ipa` 📲

✔️	`e14659b`	#7	2022-09-23 14:28:30	~1 min	`tests`	📦`log`
✔️	`e14659b`	#7	2022-09-23 14:34:38	~8 min	`android-e2e`	📦`apk` 📲
✔️	`e14659b`	#7	2022-09-23 14:34:57	~8 min	`android`	📦`apk` 📲
✔️	`e14659b`	#7	2022-09-23 14:38:59	~12 min	`ios`	📦`ipa` 📲

J-Son89 · 2022-09-19T23:12:58Z

Preview of screen

status-im-auto · 2022-09-20T09:07:07Z

97% of end-end tests have passed

Total executed tests: 87
Failed tests: 3
Passed tests: 84

IDs of failed tests: 5756,700732,3997

Failed tests (3)

Click to expand

Rerun failed tests

Class TestGroupChatMultipleDeviceMerged:

1. test_group_chat_highligted, id: 5756
Device 1: Double tap on: HomeButton Device 1: Find `HomeButton` by `xpath`: `//[contains(@content-desc,'tab, 1 out of 5')]` critical/chats/test_group_chat.py:162: in test_group_chat_highligted [self.homes[i].home_button.double_click() for i in range(3)] critical/chats/test_group_chat.py:162: in <listcomp> [self.homes[i].home_button.double_click() for i in range(3)] ../views/base_element.py:110: in double_click [self.find_element().click() for _ in range(2)] ../views/base_element.py:110: in <listcomp> [self.find_element().click() for _ in range(2)] ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 1: HomeButton by xpath: `//[contains(@content-desc,'tab, 1 out of 5')]` is not found on the screen Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot Device 3: Steps, video, logs Failure screenshot
2. test_group_chat_add_new_member_activity_centre, id: 700732
Device 3: Find `Button` by `accessibility id`: `notifications-unread-badge` Device 3: Tap on found: Button critical/chats/test_group_chat.py:118: in test_group_chat_add_new_member_activity_centre self.homes[2].get_chat(self.chat_name).click() ../views/home_view.py:257: in get_chat chat_in_ac.wait_for_element(20) ../views/base_element.py:117: in wait_for_element raise TimeoutException( Device `3`: `ActivityCenterChatElement` by` xpath`: `//*[@content-desc='chat-name-or-sender-text'][starts-with(@text,'ngnaecw')]/../..` is not found on the screen after wait_for_element Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot Device 3: Steps, video, logs Failure screenshot
3. test_group_chat_leave_relogin, id: 3997
Device 1: Double tap on: HomeButton Device 1: Find `HomeButton` by `xpath`: `//[contains(@content-desc,'tab, 1 out of 5')]` critical/chats/test_group_chat.py:178: in test_group_chat_leave_relogin [self.homes[i].home_button.double_click() for i in range(2)] critical/chats/test_group_chat.py:178: in <listcomp> [self.homes[i].home_button.double_click() for i in range(2)] ../views/base_element.py:110: in double_click [self.find_element().click() for _ in range(2)] ../views/base_element.py:110: in <listcomp> [self.find_element().click() for _ in range(2)] ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 1: HomeButton by xpath: `//[contains(@content-desc,'tab, 1 out of 5')]` is not found on the screen Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot Device 3: Steps, video, logs Failure screenshot

Passed tests (84)

Click to expand

Class TestRestoreOneDeviceMerged:

1. test_restore_set_up_wallet_sign_phrase, id: 700749
Device sessions Device 1: Steps, video, logs
2. test_restore_account_migrate_multiaccount_to_keycard_no_db_saved_add_wallet_send_tx, id: 702189
Device sessions Device 1: Steps, video, logs
3. test_restore_seed_phrase_field_validation, id: 700750
Device sessions Device 1: Steps, video, logs
4. test_restore_uppercase_whitespaces_seed_phrase_special_char_passw_logcat, id: 700748
Device sessions Device 1: Steps, video, logs

Class TestKeycardTxOneDeviceMerged:

1. test_keycard_relogin_after_restore, id: 700768
Device sessions Device 1: Steps, video, logs
2. test_keycard_send_tx_sign_message_request_stt_testdapp, id: 700769
Device sessions Device 1: Steps, video, logs
3. test_keycard_create_account_unlock_same_seed, id: 5689
Device sessions Device 1: Steps, video, logs
4. test_keycard_send_tx_eth, id: 700767
Device sessions Device 1: Steps, video, logs
5. test_keycard_wallet_recover_pairing_check_balance_after_offline_tx_history, id: 700770
Device sessions Device 1: Steps, video, logs

Class TestPublicChatMultipleDeviceMerged:

1. test_public_chat_message_edit, id: 700734
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_public_chat_unread_messages_counter, id: 5360
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_public_chat_emoji_send_copy_paste_reply, id: 700719
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_public_chat_unread_messages_counter_for_mention_relogin, id: 700718
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_public_chat_delete_chat_long_press, id: 5319
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_public_chat_link_send_open, id: 700736
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_public_chat_mark_all_messages_as_read, id: 6270
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
8. test_public_chat_links_with_previews_github_youtube_twitter_gif_send_enable, id: 700737
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
9. test_public_chat_message_send_check_timestamps_while_on_different_tab, id: 5313
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
10. test_public_chat_message_delete, id: 700735
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestPublicChatBrowserOneDeviceMerged:

1. test_public_chat_open_using_deep_link, id: 700739
Device sessions Device 1: Steps, video, logs
2. test_browser_bookmarks_create_edit_remove, id: 702077
Device sessions Device 1: Steps, video, logs
3. test_browser_blocked_url, id: 702072
Device sessions Device 1: Steps, video, logs
4. test_browser_delete_close_tabs, id: 702076
Device sessions Device 1: Steps, video, logs
5. test_browser_connection_is_secure_not_secure_warning, id: 702073
Device sessions Device 1: Steps, video, logs
6. test_browser_web3_permissions_testdapp, id: 702078
Device sessions Device 1: Steps, video, logs
7. test_public_chat_tag_message, id: 700738
Device sessions Device 1: Steps, video, logs
8. test_public_chat_navigate_to_chat_when_relaunch, id: 5396
Device sessions Device 1: Steps, video, logs
9. test_public_chat_copy_and_paste_message_in_chat_input, id: 5317
Device sessions Device 1: Steps, video, logs
10. test_public_chat_fetch_more_history, id: 5675
Device sessions Device 1: Steps, video, logs
11. test_browser_offline, id: 702075
Device sessions Device 1: Steps, video, logs
12. test_browser_invalid_url, id: 702074
Device sessions Device 1: Steps, video, logs

Class TestOnboardingOneDeviceMerged:

1. test_onboarding_add_new_multiaccount_username_by_position_pass_validation, id: 700747
Device sessions Device 1: Steps, video, logs
2. test_onboarding_home_initial_popup, id: 700742
Device sessions Device 1: Steps, video, logs
3. test_onboarding_share_contact_address, id: 700743
Device sessions Device 1: Steps, video, logs
4. test_onboarding_backup_seed_phrase_restore_same_login_logcat, id: 700745
Device sessions Device 1: Steps, video, logs
5. test_onboarding_cant_sign_in_with_invalid_password_logcat, id: 700746
Device sessions Device 1: Steps, video, logs
6. test_onboarding_share_wallet_address, id: 700744
Device sessions Device 1: Steps, video, logs

Class TestSendTxDeviceMerged:

1. test_send_tx_eth_check_logcat, id: 700763
Device sessions Device 1: Steps, video, logs
2. test_send_tx_custom_token_18_decimals_invalid_password, id: 700765
Device sessions Device 1: Steps, video, logs
3. test_send_tx_token_8_decimals, id: 700764
Device sessions Device 1: Steps, video, logs
4. test_send_tx_set_recipient_options, id: 700757
Device sessions Device 1: Steps, video, logs
5. test_send_tx_sign_message_2tx_in_batch_tx_filters_request_stt_testdapp, id: 5342
Device sessions Device 1: Steps, video, logs

Class TestGroupChatMultipleDeviceMerged:

1. test_group_chat_push_system_messages_when_invited, id: 3994
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
2. test_group_chat_join_send_text_messages_push, id: 700731
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
3. test_group_chat_offline_pn, id: 3998
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs

Class TestEnsStickersMultipleDevicesMerged:

1. test_sticker_1_1_public_chat_mainnet, id: 702157
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_ens_command_send_tx_eth_1_1_chat, id: 702153
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_ens_mention_push_highlighted_public_chat, id: 702156
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_ens_mention_nickname_1_1_chat, id: 702155
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_ens_purchased_in_profile, id: 702152
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_start_new_chat_public_key_validation, id: 702158
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestCommandsMultipleDevicesMerged:

1. test_1_1_chat_command_decline_eth_push_changing_state, id: 6265
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_1_1_chat_command_request_and_send_tx_stt_in_1_1_chat_offline, id: 6263
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_1_1_chat_command_send_tx_eth_outgoing_tx_push, id: 6253
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestOneToOneChatMultipleSharedDevices:

1. test_1_1_chat_text_message_edit_delete_push_disappear, id: 695843
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_1_1_chat_message_reaction, id: 6315
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_1_1_chat_audio_message_with_push, id: 6316
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_1_1_chat_emoji_send_reply_and_open_link, id: 5373
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_1_1_chat_image_send_save_reply, id: 6305
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 5310
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_1_1_chat_non_latin_message_to_newly_added_contact_with_profile_picture_on_different_networks, id: 5315
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
8. test_1_1_chat_delete_via_delete_button_relogin, id: 5387
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
9. test_1_1_chat_push_emoji, id: 6283
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestPairingSyncMultipleDevicesMerged:

1. test_pairing_sync_clear_history, id: 702394
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_pairing_sync_contacts_block_unblock, id: 702196
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_pairing_sync_initial_profile_picture, id: 702392
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_pairing_sync_initial_bookmarks, id: 702393
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_pairing_sync_initial_contacts_blocked_users, id: 702194
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_pairing_sync_1_1_chat_message, id: 702198
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_pairing_sync_public_chat_add_remove, id: 702199
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
8. test_pairing_sync_initial_public_chats, id: 702195
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
9. test_pairing_sync_contacts_add_remove_set_nickname_ens, id: 702197
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestWalletManagementDeviceMerged:

1. test_wallet_manage_assets, id: 700758
Device sessions Device 1: Steps, video, logs
2. test_wallet_add_account_seed_phrase_validation, id: 700762
Device sessions Device 1: Steps, video, logs
3. test_wallet_add_hide_unhide_account_private_key, id: 700761
Device sessions Device 1: Steps, video, logs
4. test_wallet_add_delete_watch_only_account, id: 700760
Device sessions Device 1: Steps, video, logs
5. test_wallet_fetching_balance_after_offline_insufficient_funds_errors, id: 700766
Device sessions Device 1: Steps, video, logs
6. test_wallet_add_account_generate_new, id: 700759
Device sessions Device 1: Steps, video, logs
7. test_wallet_tx_history_copy_tx_hash_on_cellular, id: 700756
Device sessions Device 1: Steps, video, logs

Class TestContactBlockMigrateKeycardMultipleSharedDevices:

1. test_contact_block_unblock_public_chat_offline, id: 702176
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_contact_add_remove_mention_default_username_nickname_public_chat, id: 702175
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_keycard_command_send_tx_eth_1_1_chat, id: 702186
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_restore_account_migrate_multiaccount_to_keycard_db_saved, id: 702177
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_cellular_settings_on_off_public_chat_fetching_history, id: 702188
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

ibrkhalil

lgtm

src/quo2/components/list_items/channel.cljs

src/quo2/foundations/colors.cljs

src/quo2/components/list_items/channel.cljs

src/quo2/screens/list_items/channel.cljs

J-Son89 added the new-design [quo2] label Sep 19, 2022

J-Son89 self-assigned this Sep 19, 2022

J-Son89 commented Sep 19, 2022

View reviewed changes

src/quo2/foundations/colors.cljs Outdated Show resolved Hide resolved

J-Son89 requested review from Parveshdhull, ibrkhalil, flexsurfer, erikseppanen, ilmotta and jo-mut September 19, 2022 23:33

flexsurfer approved these changes Sep 20, 2022

View reviewed changes

ibrkhalil approved these changes Sep 20, 2022

View reviewed changes

ilmotta reviewed Sep 20, 2022

View reviewed changes

ilmotta approved these changes Sep 20, 2022

View reviewed changes

J-Son89 force-pushed the jc/add-channel-list-item branch from ba08e3d to 2887049 Compare September 20, 2022 12:03

erikseppanen reviewed Sep 20, 2022

View reviewed changes

src/quo2/components/list_items/channel.cljs Outdated Show resolved Hide resolved

src/quo2/screens/list_items/channel.cljs Show resolved Hide resolved

J-Son89 force-pushed the jc/add-channel-list-item branch 4 times, most recently from 35eb9b1 to abcf097 Compare September 23, 2022 13:11

J-Son89 added 2 commits September 23, 2022 15:25

feat: add list item - channel component to quo2 library

0500b64

fix: adjust size and position of icon for lock in channel avatar

e14659b

J-Son89 force-pushed the jc/add-channel-list-item branch from abcf097 to e14659b Compare September 23, 2022 14:26

J-Son89 merged commit 1fb71bd into develop Sep 23, 2022

J-Son89 deleted the jc/add-channel-list-item branch September 23, 2022 14:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Jc/add channel list item #14040

Jc/add channel list item #14040

J-Son89 commented Sep 19, 2022

J-Son89 Sep 19, 2022

status-im-auto commented Sep 19, 2022 •

edited

Loading

J-Son89 commented Sep 19, 2022

status-im-auto commented Sep 20, 2022

Class TestGroupChatMultipleDeviceMerged:

Class TestRestoreOneDeviceMerged:

Class TestKeycardTxOneDeviceMerged:

Class TestPublicChatMultipleDeviceMerged:

Class TestPublicChatBrowserOneDeviceMerged:

Class TestOnboardingOneDeviceMerged:

Class TestSendTxDeviceMerged:

Class TestGroupChatMultipleDeviceMerged:

Class TestEnsStickersMultipleDevicesMerged:

Class TestCommandsMultipleDevicesMerged:

Class TestOneToOneChatMultipleSharedDevices:

Class TestPairingSyncMultipleDevicesMerged:

Class TestWalletManagementDeviceMerged:

Class TestContactBlockMigrateKeycardMultipleSharedDevices:

ibrkhalil left a comment

Jc/add channel list item #14040

Jc/add channel list item #14040

Conversation

J-Son89 commented Sep 19, 2022

Steps to test

J-Son89 Sep 19, 2022

Choose a reason for hiding this comment

status-im-auto commented Sep 19, 2022 • edited Loading

Jenkins Builds

J-Son89 commented Sep 19, 2022

status-im-auto commented Sep 20, 2022

97% of end-end tests have passed

Failed tests (3)

Class TestGroupChatMultipleDeviceMerged:

Passed tests (84)

Class TestRestoreOneDeviceMerged:

Class TestKeycardTxOneDeviceMerged:

Class TestPublicChatMultipleDeviceMerged:

Class TestPublicChatBrowserOneDeviceMerged:

Class TestOnboardingOneDeviceMerged:

Class TestSendTxDeviceMerged:

Class TestGroupChatMultipleDeviceMerged:

Class TestEnsStickersMultipleDevicesMerged:

Class TestCommandsMultipleDevicesMerged:

Class TestOneToOneChatMultipleSharedDevices:

Class TestPairingSyncMultipleDevicesMerged:

Class TestWalletManagementDeviceMerged:

Class TestContactBlockMigrateKeycardMultipleSharedDevices:

ibrkhalil left a comment

Choose a reason for hiding this comment

status-im-auto commented Sep 19, 2022 •

edited

Loading