RE: User avatar component #13839

ibrkhalil · 2022-08-22T20:23:00Z

fixes: #13560
status: ready

ibrkhalil · 2022-08-22T20:23:46Z

Same as #13722
But to solve conflicts

status-im-auto · 2022-08-22T20:30:37Z

Jenkins Builds

Click to see older builds (43)

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`d2cfc99`	#1	2022-08-22 20:30:36	~7 min	`android`	📦`apk` 📲
✔️	`d2cfc99`	#1	2022-08-22 20:30:49	~7 min	`android-e2e`	📦`apk` 📲
✔️	`d2cfc99`	#1	2022-08-22 20:42:43	~19 min	`ios`	📦`ipa` 📲

✔️	`6f258f5`	#2	2022-08-23 16:04:54	~8 min	`android`	📦`apk` 📲
✔️	`6f258f5`	#2	2022-08-23 16:05:24	~8 min	`android-e2e`	📦`apk` 📲
✔️	`6f258f5`	#2	2022-08-23 16:15:18	~18 min	`ios`	📦`ipa` 📲

❌	`eb92091`	#3	2022-08-27 07:39:56	~13 sec	`ios`	📄`log`
❌	`eb92091`	#3	2022-08-27 07:39:57	~15 sec	`android-e2e`	📄`log`
❌	`eb92091`	#3	2022-08-27 07:39:59	~15 sec	`android`	📄`log`

❌	`e203899`	#4	2022-08-27 09:02:43	~40 sec	`android-e2e`	📄`log`
❌	`e203899`	#4	2022-08-27 09:02:53	~50 sec	`android`	📄`log`
❌	`e203899`	#1	2022-08-27 09:03:12	~1 min	`tests`	📄`log`
❌	`e203899`	#4	2022-08-27 09:03:36	~1 min	`ios`	📄`log`
❌	`e203899`	#1	2022-09-02 12:01:36	~10 min	`android`	📄`log`
❌	`e203899`	#1	2022-09-02 12:16:57	~24 min	`android-e2e`	📄`log`

❌	`75e7c58`	#2	2022-09-03 09:19:53	~19 sec	`ios`	📄`log`
❌	`75e7c58`	#2	2022-09-03 09:19:55	~26 sec	`android-e2e`	📄`log`
❌	`75e7c58`	#2	2022-09-03 09:19:57	~23 sec	`android`	📄`log`
❌	`75e7c58`	#2	2022-09-03 09:20:02	~29 sec	`tests`	📄`log`

❌	`5b1ecc2`	#3	2022-09-05 13:18:26	~14 sec	`android`	📄`log`
❌	`5b1ecc2`	#3	2022-09-05 13:19:04	~52 sec	`tests`	📄`log`
❌	`5b1ecc2`	#3	2022-09-05 13:19:26	~1 min	`android-e2e`	📄`log`
❌	`5b1ecc2`	#3	2022-09-05 13:20:16	~2 min	`ios`	📄`log`

❌	`ded6228`	#4	2022-09-05 17:58:14	~15 sec	`android-e2e`	📄`log`
❌	`ded6228`	#4	2022-09-05 17:58:17	~13 sec	`tests`	📄`log`
❌	`ded6228`	#4	2022-09-05 17:58:18	~14 sec	`ios`	📄`log`
❌	`ded6228`	#4	2022-09-05 17:58:19	~15 sec	`android`	📄`log`

❌	`475c066`	#5	2022-09-05 18:13:34	~14 sec	`ios`	📄`log`
❌	`475c066`	#5	2022-09-05 18:13:43	~24 sec	`tests`	📄`log`
❌	`475c066`	#5	2022-09-05 18:13:47	~28 sec	`android-e2e`	📄`log`
❌	`475c066`	#5	2022-09-05 18:13:48	~29 sec	`android`	📄`log`

❌	`88e0c0b`	#6	2022-09-05 18:17:34	~15 sec	`ios`	📄`log`
❌	`88e0c0b`	#6	2022-09-05 18:17:35	~16 sec	`android-e2e`	📄`log`
❌	`88e0c0b`	#6	2022-09-05 18:17:50	~31 sec	`android`	📄`log`

❌	`e0d9650`	#7	2022-09-05 19:02:41	~15 sec	`android-e2e`	📄`log`
❌	`e0d9650`	#7	2022-09-05 19:02:44	~14 sec	`ios`	📄`log`
❌	`e0d9650`	#7	2022-09-05 19:02:45	~15 sec	`android`	📄`log`

❌	`0e432b2`	#8	2022-09-05 19:06:43	~13 sec	`ios`	📄`log`
❌	`0e432b2`	#8	2022-09-05 19:06:45	~15 sec	`android`	📄`log`
❌	`0e432b2`	#8	2022-09-05 19:06:45	~15 sec	`android-e2e`	📄`log`
❌	`0e432b2`	#6	2022-09-05 19:06:47	~12 sec	`tests`	📄`log`

❌	`01fbd97`	#7	2022-09-05 19:11:27	~1 min	`tests`	📄`log`

❌	`db3f219`	#8	2022-09-05 19:14:03	~1 min	`tests`	📄`log`

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`855f967`	#9	2022-09-05 19:17:53	~1 min	`tests`	📦`log`

✔️	`18631c1`	#10	2022-09-05 19:20:53	~1 min	`tests`	📦`log`
✔️	`18631c1`	#12	2022-09-05 19:26:28	~7 min	`android-e2e`	📦`apk` 📲
✔️	`18631c1`	#12	2022-09-05 19:26:44	~7 min	`android`	📦`apk` 📲
✔️	`18631c1`	#12	2022-09-05 19:33:19	~14 min	`ios`	📦`ipa` 📲

src/quo2/components/user_avatar.cljs

J-Son89 · 2022-08-25T16:41:41Z

i checked out your pr for a quick check of designs:

I think you are missing the font-weight for the text here.

Also it looks like the dot indicator positioning is a bit off. 🤔

ibrkhalil · 2022-08-31T19:00:46Z

i checked out your pr for a quick check of designs:

I think you are missing the font-weight for the text here.

Also it looks like the dot indicator positioning is a bit off. thinking

Hey @J-Son89 Can you please check again ?

J-Son89 · 2022-08-31T19:31:10Z

i checked out your pr for a quick check of designs:
I think you are missing the font-weight for the text here.
Also it looks like the dot indicator positioning is a bit off. thinking

Hey @J-Son89 Can you please check again ?

yep, I'll give it a look

src/quo2/screens/user_avatar.cljs

J-Son89 · 2022-09-01T21:04:30Z

Text size on the Big implementation looks good but the ring is still slightly off.

Maybe it's okay though, not sure how pixel perfect designs need to be. 🤷‍♂️

J-Son89 · 2022-09-01T21:07:38Z

Similar for Medium

J-Son89 · 2022-09-01T21:12:53Z

Small size with ring looks good 👍

Also I checked the Big without the ring and the dot seems to sit nicel. Probably needs to be slightly adjusted for when the ring is being used.

ibrkhalil · 2022-09-03T09:18:51Z

Thanks JC
I read about VRT and applied it
Big:

Medium:

Rebase

…gin (#13918)

* User avatar component Rebase * clean * Add icons * fix keycard account shown as regular account on theme change while login (#13918) * rebase * clean * clean Co-authored-by: Parvesh Monu <[email protected]>

ibrkhalil changed the title ~~User avatar component~~ RE: User avatar component Aug 22, 2022

Parveshdhull assigned ibrkhalil Aug 23, 2022

ibrkhalil requested review from flexsurfer and siddarthkay August 24, 2022 19:43

flexsurfer reviewed Aug 25, 2022

View reviewed changes

J-Son89 reviewed Aug 25, 2022

View reviewed changes

src/quo2/components/user_avatar.cljs Outdated Show resolved Hide resolved

flexsurfer added the new-design [quo2] label Aug 30, 2022

J-Son89 reviewed Sep 1, 2022

View reviewed changes

src/quo2/screens/user_avatar.cljs Outdated Show resolved Hide resolved

J-Son89 approved these changes Sep 5, 2022

View reviewed changes

ibrkhalil force-pushed the issue-13560-2 branch 2 times, most recently from ded6228 to 475c066 Compare September 5, 2022 18:13

ibrkhalil requested review from churik and jakubgs as code owners September 5, 2022 18:13

ibrkhalil force-pushed the issue-13560-2 branch from 475c066 to 88e0c0b Compare September 5, 2022 18:17

ibrkhalil removed request for jakubgs, churik and siddarthkay September 5, 2022 19:06

ibrkhalil added 3 commits September 5, 2022 21:08

User avatar component

77e9de1

Rebase

clean

1385ec9

Add icons

16dd09d

Parveshdhull and others added 2 commits September 5, 2022 21:08

fix keycard account shown as regular account on theme change while lo…

d65e6b1

…gin (#13918)

rebase

01fbd97

ibrkhalil force-pushed the issue-13560-2 branch from 0e432b2 to 01fbd97 Compare September 5, 2022 19:09

ibrkhalil and others added 3 commits September 5, 2022 21:11

clean

db3f219

clean

855f967

Merge branch 'develop' into issue-13560-2

18631c1

ibrkhalil merged commit 0300070 into develop Sep 5, 2022

ibrkhalil deleted the issue-13560-2 branch September 5, 2022 19:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

RE: User avatar component #13839

RE: User avatar component #13839

ibrkhalil commented Aug 22, 2022 •

edited

Loading

ibrkhalil commented Aug 22, 2022

status-im-auto commented Aug 22, 2022 •

edited

Loading

J-Son89 commented Aug 25, 2022

ibrkhalil commented Aug 31, 2022

J-Son89 commented Aug 31, 2022

J-Son89 commented Sep 1, 2022

J-Son89 commented Sep 1, 2022

J-Son89 commented Sep 1, 2022

ibrkhalil commented Sep 3, 2022 •

edited

Loading

RE: User avatar component #13839

RE: User avatar component #13839

Conversation

ibrkhalil commented Aug 22, 2022 • edited Loading

ibrkhalil commented Aug 22, 2022

status-im-auto commented Aug 22, 2022 • edited Loading

Jenkins Builds

J-Son89 commented Aug 25, 2022

ibrkhalil commented Aug 31, 2022

J-Son89 commented Aug 31, 2022

J-Son89 commented Sep 1, 2022

J-Son89 commented Sep 1, 2022

J-Son89 commented Sep 1, 2022

ibrkhalil commented Sep 3, 2022 • edited Loading

ibrkhalil commented Aug 22, 2022 •

edited

Loading

status-im-auto commented Aug 22, 2022 •

edited

Loading

ibrkhalil commented Sep 3, 2022 •

edited

Loading