feat: lottie splash screen #13714

yqrashawn · 2022-07-23T16:02:08Z

resolve #12790

Summary

Use https://github.com/HwangTaehyun/react-native-lottie-splash-screen to add lottie support in splash screen

Notes
- iOS doesn't allow animation in launch screen, the solution is blank launch screen + lottie animation in root view:
  1. Attaching the animated view into root view
  2. Show the animated view as early as possible
  3. Hide it once app loaded
Progress
- iOS
  - works
  - Find out why we need to call hide on splash screen twice
  - Find out why we need to call hide on splash screen with setTimeout
  - dark/light mode
- Android
  - dark/light mode
- Update related tests
  - react-native-lottie-splash-screen breaks make test, waiting for upstream [fix] Set pkg type to module HwangTaehyun/react-native-lottie-splash-screen#44
  - the above package is no longer in tests
- Update related doc
  - doc/DEPENDENCIES.md
- adjust to the right size

Review notes

glog and react-native-blur in ios/Podfile.lock changed when running make shell TARGET=ios.

Testing notes

Platforms

Android
iOS

Steps to test

Open Status
There will be a static launch screen then the animated one

status: ready

status-github-bot · 2022-07-23T16:02:13Z

Hey @yqrashawn, and thank you so much for making your first pull request in status-mobile! ❤️ Please help us make your experience better by filling out this brief questionnaire https://goo.gl/forms/uWqNcVpVz7OIopXg2

status-im-auto · 2022-07-23T16:07:56Z

Jenkins Builds

Click to see older builds (58)

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
❌	`6a5ab10`	#1	2022-07-23 16:07:56	~5 min	`android-e2e`	📄`log`
❌	`6a5ab10`	#1	2022-07-23 16:07:59	~5 min	`android`	📄`log`
❌	`6a5ab10`	#1	2022-07-23 16:11:52	~9 min	`ios`	📄`log`

❌	`1784b14`	#2	2022-07-24 01:29:44	~5 min	`android-e2e`	📄`log`
❌	`1784b14`	#2	2022-07-24 01:29:45	~5 min	`android`	📄`log`
❌	`1784b14`	#2	2022-07-24 01:35:05	~10 min	`ios`	📄`log`

❌	`8ca80ab`	#4	2022-07-24 01:43:11	~5 min	`android`	📄`log`
❌	`8ca80ab`	#4	2022-07-24 01:43:12	~5 min	`android-e2e`	📄`log`
❌	`8ca80ab`	#4	2022-07-24 01:46:13	~8 min	`ios`	📄`log`

❌	`3a6d17f`	#5	2022-07-24 02:25:34	~5 min	`android-e2e`	📄`log`
❌	`3a6d17f`	#5	2022-07-24 02:25:42	~5 min	`android`	📄`log`
❌	`3a6d17f`	#5	2022-07-24 02:29:56	~9 min	`ios`	📄`log`

❌	`a53c556`	#6	2022-07-24 07:02:49	~5 min	`android-e2e`	📄`log`
❌	`a53c556`	#6	2022-07-24 07:02:58	~5 min	`android`	📄`log`
❌	`a53c556`	#6	2022-07-24 07:07:27	~9 min	`ios`	📄`log`

❌	`78c1aff`	#7	2022-07-24 07:18:57	~5 min	`android-e2e`	📄`log`
❌	`78c1aff`	#7	2022-07-24 07:19:03	~5 min	`android`	📄`log`
❌	`78c1aff`	#7	2022-07-24 07:22:37	~8 min	`ios`	📄`log`

❌	`774c527`	#8	2022-07-24 07:37:28	~5 min	`android-e2e`	📄`log`
❌	`774c527`	#8	2022-07-24 07:40:43	~8 min	`ios`	📄`log`
❌	`774c527`	#8	2022-07-24 08:02:16	~30 min	`android`	📄`log`

❌	`69060ed`	#9	2022-07-24 09:59:47	~5 min	`android-e2e`	📄`log`
❌	`69060ed`	#9	2022-07-24 10:03:37	~9 min	`ios`	📄`log`
❌	`69060ed`	#9	2022-07-24 10:24:35	~30 min	`android`	📄`log`

❌	`cff3138`	#10	2022-07-24 12:39:44	~5 min	`android-e2e`	📄`log`
❌	`cff3138`	#10	2022-07-24 12:44:18	~10 min	`ios`	📄`log`
❌	`cff3138`	#10	2022-07-24 13:04:33	~30 min	`android`	📄`log`

❌	`8648ce5`	#11	2022-07-24 13:42:18	~5 min	`android`	📄`log`
❌	`8648ce5`	#11	2022-07-24 13:42:18	~5 min	`android-e2e`	📄`log`
❌	`8648ce5`	#11	2022-07-24 13:46:40	~9 min	`ios`	📄`log`

✔️	`10c8346`	#12	2022-07-25 06:02:19	~9 min	`android-e2e`	📦`apk` 📲
❌	`10c8346`	#12	2022-07-25 06:02:19	~9 min	`ios`	📄`log`
✔️	`10c8346`	#12	2022-07-25 06:02:51	~9 min	`android`	📦`apk` 📲

❌	`6aa0da9`	#13	2022-07-25 07:58:32	~9 min	`android`	📄`log`
❌	`6aa0da9`	#13	2022-07-25 07:58:33	~9 min	`android-e2e`	📄`log`
✔️	`6aa0da9`	#13	2022-07-25 08:05:29	~15 min	`ios`	📦`ipa` 📲

❌	`39ea9e9`	#14	2022-07-25 09:14:46	~8 min	`android-e2e`	📄`log`
❌	`39ea9e9`	#14	2022-07-25 09:15:09	~8 min	`android`	📄`log`
✔️	`39ea9e9`	#14	2022-07-25 09:26:20	~19 min	`ios`	📦`ipa` 📲

✔️	`9ea78c5`	#15	2022-07-25 13:14:58	~21 min	`android-e2e`	📦`apk` 📲
✔️	`9ea78c5`	#15	2022-07-25 13:16:48	~23 min	`android`	📦`apk` 📲
✔️	`9ea78c5`	#15	2022-07-25 13:53:45	~1 hr 0 min	`ios`	📦`ipa` 📲

✔️	`2b5c9c0`	#16	2022-07-25 14:20:24	~17 min	`android-e2e`	📦`apk` 📲
✔️	`2b5c9c0`	#16	2022-07-25 14:20:50	~18 min	`android`	📦`apk` 📲

✔️	`db393d3`	#17	2022-07-25 14:40:36	~9 min	`android-e2e`	📦`apk` 📲
✔️	`db393d3`	#17	2022-07-25 14:40:39	~9 min	`android`	📦`apk` 📲

✔️	`322c811`	#18	2022-07-25 14:55:26	~9 min	`android`	📦`apk` 📲
✔️	`322c811`	#18	2022-07-25 14:56:30	~10 min	`android-e2e`	📦`apk` 📲
✔️	`322c811`	#18	2022-07-25 14:58:36	~12 min	`ios`	📦`ipa` 📲

✔️	`4aa54ff`	#19	2022-07-26 00:17:01	~9 min	`android`	📦`apk` 📲
✔️	`4aa54ff`	#19	2022-07-26 00:17:20	~9 min	`android-e2e`	📦`apk` 📲
✔️	`4aa54ff`	#19	2022-07-26 00:18:42	~10 min	`ios`	📦`ipa` 📲

✔️	`cc0036b`	#20	2022-07-29 12:44:03	~9 min	`android`	📦`apk` 📲
✔️	`cc0036b`	#20	2022-07-29 12:44:16	~9 min	`android-e2e`	📦`apk` 📲
✔️	`cc0036b`	#20	2022-07-29 12:45:00	~10 min	`ios`	📦`ipa` 📲

✔️	`4468d78`	#21	2022-07-29 14:32:27	~11 min	`android-e2e`	📦`apk` 📲
✔️	`4468d78`	#21	2022-07-29 14:33:43	~12 min	`ios`	📦`ipa` 📲
✔️	`4468d78`	#22	2022-07-29 15:24:56	~9 min	`android`	📦`apk` 📲

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
❌	`99e8674`	#22	2022-08-01 12:23:39	~10 min	`ios`	📄`log`
✔️	`99e8674`	#23	2022-08-01 12:24:26	~11 min	`android`	📦`apk` 📲
✔️	`99e8674`	#23	2022-08-01 12:58:36	~9 min	`android-e2e`	📦`apk` 📲
✔️	`99e8674`	#23	2022-08-01 12:59:14	~10 min	`ios`	📦`ipa` 📲

✔️	`b952f34`	#25	2022-08-02 10:03:58	~10 min	`android-e2e`	📦`apk` 📲
✔️	`b952f34`	#25	2022-08-02 10:05:06	~11 min	`android`	📦`apk` 📲
✔️	`b952f34`	#25	2022-08-02 10:09:10	~15 min	`ios`	📦`ipa` 📲

ios/Podfile.lock

yqrashawn · 2022-07-24T13:17:13Z

iOS:

CleanShot.2022-07-24.at.21.44.32.mp4

nix/deps/gradle/proj.list

du82 · 2022-07-24T17:21:29Z

iOS:

CleanShot.2022-07-24.at.21.44.32.mp4

I think the animated logo should be much smaller, more like the size of the current splash logo

flexsurfer · 2022-07-25T06:31:33Z

hey thank you for your contribution, it doesn't make sense to have such an approach on ios, because animation won't be visible to user, so I would keep current splash on ios

yqrashawn · 2022-07-25T06:33:50Z

hey thank you for your contribution, it doesn't make sense to have such an approach on ios, because animation won't be visible to user, so I would keep current splash on ios

I have the same concern. The animated view will delay the first view for sure.
Should I revert the iOS related changes and keep the current one?

flexsurfer · 2022-07-25T06:36:58Z

yes, i would say its better to revert ios, thank you

yqrashawn · 2022-07-25T14:05:26Z

Android:
The app crash when react loaded on my machine, still figuring out why (probably caused by version of android sdk or emulator). But it won't block the native lottie splash screen.

Changed the logo size to 128

~~https://user-images.githubusercontent.com/15090582/180795895-373e22ad-d93f-45c0-a551-e5a8269f4a85.mp4~~

jakubgs

I see no issues with Nix Gradle dependency definition changes.

yqrashawn · 2022-08-01T12:13:11Z

i believe react-native-lottie-splash-screen is a fork of library we used before, so it could be used for both ios and android, there is no reason to use two libraries

This one is done.

yqrashawn · 2022-08-01T12:13:42Z

yes @yqrashawn is right, theme is stored per multiaccount, so it applies only after sign in, for splash screen and login in scree OS theme is used

Should I open an issue for this, or it's already discussed?

status-im-auto · 2022-08-01T14:22:15Z

98% of end-end tests have passed

Total executed tests: 87
Failed tests: 2
Passed tests: 85

IDs of failed tests: 702189,5315

Failed tests (2)

Click to expand

Rerun failed tests

Class TestRestoreOneDeviceMerged:

1. test_restore_account_migrate_multiaccount_to_keycard_no_db_saved_add_wallet_send_tx, id: 702189
Device 1: Find `SignWithKeycardButton` by `xpath`: `//[contains(@text,'Sign with')]` Device 1: Enter default pin 111111 `critical/onboarding/test_onboarding_flows.py:478: in test_restore_account_migrate_multiaccount_to_keycard_no_db_saved_add_wallet_send_tx wallet.send_transaction(amount=transaction_amount_added, recipient=transaction_senders['ETH_8']['address'], ../vie` Class: TestRestoreOneDeviceMerged* Device sessions Device 1: Steps, video, logs Failure screenshot

Class TestOneToOneChatMultipleSharedDevices:

1. test_1_1_chat_non_latin_message_to_newly_added_contact_with_profile_picture_on_different_networks, id: 5315
Device 1: Find `ChatElementByText` by `xpath`: `//[starts-with(@text,'® æ ç ♥')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` Device 1: Find `Button` by `xpath`: `//[@text="Today"]` `critical/chats/test_1_1_public_chats.py:408: in test_1_1_chat_non_latin_message_to_newly_added_contact_with_profile_picture_on_different_networks [chat.verify_message_is_under_today_text(timestamp_message, self.errors) for chat in (self.chat_1, self.c` Class: TestOneToOneChatMultipleSharedDevices Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot

Passed tests (85)

Click to expand

Class TestContactBlockMigrateKeycardMultipleSharedDevices:

1. test_keycard_command_send_tx_eth_1_1_chat, id: 702186
Class: TestContactBlockMigrateKeycardMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_contact_block_unblock_public_chat_offline, id: 702176
Class: TestContactBlockMigrateKeycardMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_contact_add_remove_mention_default_username_nickname_public_chat, id: 702175
Class: TestContactBlockMigrateKeycardMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_cellular_settings_on_off_public_chat_fetching_history, id: 702188
Class: TestContactBlockMigrateKeycardMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_restore_account_migrate_multiaccount_to_keycard_db_saved, id: 702177
Class: TestContactBlockMigrateKeycardMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestPairingSyncMultipleDevicesMerged:

1. test_pairing_sync_contacts_add_remove_set_nickname_ens, id: 702197
Class: TestPairingSyncMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_pairing_sync_clear_history, id: 702394
Class: TestPairingSyncMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_pairing_sync_initial_bookmarks, id: 702393
Class: TestPairingSyncMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_pairing_sync_initial_profile_picture, id: 702392
Class: TestPairingSyncMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_pairing_sync_contacts_block_unblock, id: 702196
Class: TestPairingSyncMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_pairing_sync_initial_contacts_blocked_users, id: 702194
Class: TestPairingSyncMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_pairing_sync_initial_public_chats, id: 702195
Class: TestPairingSyncMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
8. test_pairing_sync_public_chat_add_remove, id: 702199
Class: TestPairingSyncMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
9. test_pairing_sync_1_1_chat_message, id: 702198
Class: TestPairingSyncMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestOneToOneChatMultipleSharedDevices:

1. test_1_1_chat_push_emoji, id: 6283
Class: TestOneToOneChatMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_1_1_chat_image_send_save_reply, id: 6305
Class: TestOneToOneChatMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 5310
Class: TestOneToOneChatMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_1_1_chat_message_reaction, id: 6315
Class: TestOneToOneChatMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_1_1_chat_delete_via_delete_button_relogin, id: 5387
Class: TestOneToOneChatMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_1_1_chat_emoji_send_reply_and_open_link, id: 5373
Class: TestOneToOneChatMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_1_1_chat_text_message_edit_delete_push_disappear, id: 695843
Class: TestOneToOneChatMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
8. test_1_1_chat_text_message_with_push, id: 6316
Class: TestOneToOneChatMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestGroupChatMultipleDeviceMerged:

1. test_group_chat_leave_relogin, id: 3997
Class: TestGroupChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
2. test_group_chat_highligted, id: 5756
Class: TestGroupChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
3. test_group_chat_push_system_messages_when_invited, id: 3994
Class: TestGroupChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
4. test_group_chat_join_send_text_messages_push, id: 700731
Class: TestGroupChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
5. test_group_chat_add_new_member_activity_centre, id: 700732
Class: TestGroupChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
6. test_group_chat_offline_pn, id: 3998
Class: TestGroupChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs

Class TestOnboardingOneDeviceMerged:

1. test_onboarding_share_contact_address, id: 700743
Class: TestOnboardingOneDeviceMerged Device sessions Device 1: Steps, video, logs
2. test_onboarding_add_new_multiaccount_username_by_position_pass_validation, id: 700747
Class: TestOnboardingOneDeviceMerged Device sessions Device 1: Steps, video, logs
3. test_onboarding_cant_sign_in_with_invalid_password_logcat, id: 700746
Class: TestOnboardingOneDeviceMerged Device sessions Device 1: Steps, video, logs
4. test_onboarding_share_wallet_address, id: 700744
Class: TestOnboardingOneDeviceMerged Device sessions Device 1: Steps, video, logs
5. test_onboarding_home_initial_popup, id: 700742
Class: TestOnboardingOneDeviceMerged Device sessions Device 1: Steps, video, logs
6. test_onboarding_backup_seed_phrase_restore_same_login_logcat, id: 700745
Class: TestOnboardingOneDeviceMerged Device sessions Device 1: Steps, video, logs

Class TestWalletManagementDeviceMerged:

1. test_wallet_add_account_generate_new, id: 700759
Class: TestWalletManagementDeviceMerged Device sessions Device 1: Steps, video, logs
2. test_wallet_add_hide_unhide_account_private_key, id: 700761
Class: TestWalletManagementDeviceMerged Device sessions Device 1: Steps, video, logs
3. test_wallet_add_delete_watch_only_account, id: 700760
Class: TestWalletManagementDeviceMerged Device sessions Device 1: Steps, video, logs
4. test_wallet_tx_history_copy_tx_hash_on_cellular, id: 700756
Class: TestWalletManagementDeviceMerged Device sessions Device 1: Steps, video, logs
5. test_wallet_fetching_balance_after_offline_insufficient_funds_errors, id: 700766
Class: TestWalletManagementDeviceMerged Device sessions Device 1: Steps, video, logs
6. test_wallet_add_account_seed_phrase_validation, id: 700762
Class: TestWalletManagementDeviceMerged Device sessions Device 1: Steps, video, logs
7. test_wallet_manage_assets, id: 700758
Class: TestWalletManagementDeviceMerged Device sessions Device 1: Steps, video, logs

Class TestPublicChatBrowserOneDeviceMerged:

1. test_browser_connection_is_secure_not_secure_warning, id: 702073
Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs
2. test_public_chat_copy_and_paste_message_in_chat_input, id: 5317
Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs
3. test_browser_invalid_url, id: 702074
Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs
4. test_browser_bookmarks_create_edit_remove, id: 702077
Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs
5. test_public_chat_tag_message, id: 700738
Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs
6. test_browser_offline, id: 702075
Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs
7. test_public_chat_navigate_to_chat_when_relaunch, id: 5396
Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs
8. test_public_chat_open_using_deep_link, id: 700739
Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs
9. test_browser_delete_close_tabs, id: 702076
Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs
10. test_browser_blocked_url, id: 702072
Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs
11. test_browser_web3_permissions_testdapp, id: 702078
Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs
12. test_public_chat_fetch_more_history, id: 5675
Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs

Class TestCommandsMultipleDevicesMerged:

1. test_1_1_chat_command_send_tx_eth_outgoing_tx_push, id: 6253
Class: TestCommandsMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_1_1_chat_command_decline_eth_push_changing_state, id: 6265
Class: TestCommandsMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_1_1_chat_command_request_and_send_tx_stt_in_1_1_chat_offline, id: 6263
Class: TestCommandsMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestRestoreOneDeviceMerged:

1. test_restore_uppercase_whitespaces_seed_phrase_special_char_passw_logcat, id: 700748
Class: TestRestoreOneDeviceMerged Device sessions Device 1: Steps, video, logs
2. test_restore_set_up_wallet_sign_phrase, id: 700749
Class: TestRestoreOneDeviceMerged Device sessions Device 1: Steps, video, logs
3. test_restore_seed_phrase_field_validation, id: 700750
Class: TestRestoreOneDeviceMerged Device sessions Device 1: Steps, video, logs

Class TestEnsStickersMultipleDevicesMerged:

1. test_start_new_chat_public_key_validation, id: 702158
Class: TestEnsStickersMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_sticker_1_1_public_chat_mainnet, id: 702157
Class: TestEnsStickersMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_ens_command_send_tx_eth_1_1_chat, id: 702153
Class: TestEnsStickersMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_ens_mention_push_highlighted_public_chat, id: 702156
Class: TestEnsStickersMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_ens_mention_nickname_1_1_chat, id: 702155
Class: TestEnsStickersMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_ens_purchased_in_profile, id: 702152
Class: TestEnsStickersMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestSendTxDeviceMerged:

1. test_send_tx_custom_token_18_decimals_invalid_password, id: 700765
Class: TestSendTxDeviceMerged Device sessions Device 1: Steps, video, logs
2. test_send_tx_token_8_decimals, id: 700764
Class: TestSendTxDeviceMerged Device sessions Device 1: Steps, video, logs
3. test_send_tx_set_recipient_options, id: 700757
Class: TestSendTxDeviceMerged Device sessions Device 1: Steps, video, logs
4. test_send_tx_eth_check_logcat, id: 700763
Class: TestSendTxDeviceMerged Device sessions Device 1: Steps, video, logs
5. test_send_tx_sign_message_2tx_in_batch_tx_filters_request_stt_testdapp, id: 5342
Class: TestSendTxDeviceMerged Device sessions Device 1: Steps, video, logs

Class TestKeycardTxOneDeviceMerged:

1. test_keycard_send_tx_eth, id: 700767
Class: TestKeycardTxOneDeviceMerged Device sessions Device 1: Steps, video, logs
2. test_keycard_create_account_unlock_same_seed, id: 5689
Class: TestKeycardTxOneDeviceMerged Device sessions Device 1: Steps, video, logs
3. test_keycard_wallet_recover_pairing_check_balance_after_offline_tx_history, id: 700770
Class: TestKeycardTxOneDeviceMerged Device sessions Device 1: Steps, video, logs
4. test_keycard_relogin_after_restore, id: 700768
Class: TestKeycardTxOneDeviceMerged Device sessions Device 1: Steps, video, logs
5. test_keycard_send_tx_sign_message_request_stt_testdapp, id: 700769
Class: TestKeycardTxOneDeviceMerged Device sessions Device 1: Steps, video, logs

Class TestPublicChatMultipleDeviceMerged:

1. test_public_chat_link_send_open, id: 700736
Class: TestPublicChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_public_chat_message_delete, id: 700735
Class: TestPublicChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_public_chat_unread_messages_counter, id: 5360
Class: TestPublicChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_public_chat_unread_messages_counter_for_mention_relogin, id: 700718
Class: TestPublicChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_public_chat_delete_chat_long_press, id: 5319
Class: TestPublicChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_public_chat_message_send_check_timestamps_while_on_different_tab, id: 5313
Class: TestPublicChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_public_chat_emoji_send_copy_paste_reply, id: 700719
Class: TestPublicChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
8. test_public_chat_mark_all_messages_as_read, id: 6270
Class: TestPublicChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
9. test_public_chat_links_with_previews_github_youtube_twitter_gif_send_enable, id: 700737
Class: TestPublicChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
10. test_public_chat_message_edit, id: 700734
Class: TestPublicChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

qoqobolo · 2022-08-01T15:02:28Z

@yqrashawn thanks for your work!

Tested:

Android (two real devices and several emulators), iOS
dark/light mode: combinations of mode settings on the device and in the application
auto-rotate
with PNs enabled
different account types
new installation without accounts (first opening), with one and several created accounts
custom themes on devices
with saved password / biometric login
with new UI enabled

LGTM. No issues found (e2e failures are not PR-related), PR can be merged.
cc @flexsurfer

flexsurfer

we need to have only one dependency

yqrashawn · 2022-08-02T09:28:09Z

we need to have only one dependency

Hi, react-native-splash-screen is removed in the latest commit.

react-native.config.js

android/app/src/main/java/im/status/ethereum/MainApplication.java

Signed-off-by: yqrashawn <[email protected]>

flexsurfer

great job! thank you

Signed-off-by: yqrashawn <[email protected]>

yqrashawn · 2022-08-02T10:00:35Z

great job! thank you

Thanks for your patience.

[#13714] feat: lottie splash screen

[status-im#13714] feat: lottie splash screen

yqrashawn force-pushed the feat/lottie-splash-screen branch 6 times, most recently from 69060ed to cff3138 Compare July 24, 2022 12:33

yqrashawn changed the title ~~feat: lottie splash screen WIP~~ feat: lottie splash screen Jul 24, 2022

yqrashawn commented Jul 24, 2022

View reviewed changes

ios/Podfile.lock Outdated Show resolved Hide resolved

yqrashawn marked this pull request as ready for review July 24, 2022 12:48

yqrashawn requested a review from jakubgs as a code owner July 24, 2022 12:48

yqrashawn force-pushed the feat/lottie-splash-screen branch from cff3138 to 8648ce5 Compare July 24, 2022 13:36

Parveshdhull reviewed Jul 24, 2022

View reviewed changes

nix/deps/gradle/proj.list Outdated Show resolved Hide resolved

Parveshdhull added the external label Jul 24, 2022

yqrashawn marked this pull request as draft July 25, 2022 08:56

yqrashawn force-pushed the feat/lottie-splash-screen branch 2 times, most recently from 39ea9e9 to 9ea78c5 Compare July 25, 2022 12:53

yqrashawn marked this pull request as ready for review July 25, 2022 14:43

yqrashawn requested a review from Parveshdhull July 25, 2022 14:44

yqrashawn force-pushed the feat/lottie-splash-screen branch from db393d3 to 322c811 Compare July 25, 2022 14:45

jakubgs approved these changes Jul 25, 2022

View reviewed changes

yqrashawn force-pushed the feat/lottie-splash-screen branch from 322c811 to 4aa54ff Compare July 26, 2022 00:07

qoqobolo added the Tested - OK label Aug 1, 2022

flexsurfer requested changes Aug 2, 2022

View reviewed changes

flexsurfer reviewed Aug 2, 2022

View reviewed changes

react-native.config.js Outdated Show resolved Hide resolved

flexsurfer reviewed Aug 2, 2022

View reviewed changes

android/app/src/main/java/im/status/ethereum/MainApplication.java Outdated Show resolved Hide resolved

yqrashawn added 10 commits August 2, 2022 17:47

feat: deps and ios

899e4e9

Signed-off-by: yqrashawn <[email protected]>

feat: android

0edfa94

Signed-off-by: yqrashawn <[email protected]>

docs: lottie splash in deps doc

a44adff

chore: nix update gradle and pods

96d7736

chore: revert ios changes, nix update

b4ed51b

Signed-off-by: yqrashawn <[email protected]>

fix: animation view size to 128

e379659

docs: add react-native-splash-screen doc back

a449e8c

fix: remove manual linking

d587d32

fix: consistent status bar color

e8ff5cd

refactor: replace splash-screen with lottie-splash-screen

a2e981b

yqrashawn force-pushed the feat/lottie-splash-screen branch from 99e8674 to 7a88b4d Compare August 2, 2022 09:48

flexsurfer approved these changes Aug 2, 2022

View reviewed changes

refactor: remove redundant code

b952f34

Signed-off-by: yqrashawn <[email protected]>

yqrashawn force-pushed the feat/lottie-splash-screen branch from 7a88b4d to b952f34 Compare August 2, 2022 09:53

flexsurfer merged commit 98ca311 into status-im:develop Aug 2, 2022

yqrashawn deleted the feat/lottie-splash-screen branch August 2, 2022 11:52

ibrkhalil pushed a commit that referenced this pull request Aug 3, 2022

feat: lottie splash screen (#13714)

4f444f3

[#13714] feat: lottie splash screen

chrispader pushed a commit to chrispader/status-mobile that referenced this pull request Aug 4, 2022

feat: lottie splash screen (status-im#13714)

f12acf6

[status-im#13714] feat: lottie splash screen

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: lottie splash screen #13714

feat: lottie splash screen #13714

yqrashawn commented Jul 23, 2022 •

edited

Loading

status-github-bot bot commented Jul 23, 2022

status-im-auto commented Jul 23, 2022 •

edited

Loading

yqrashawn commented Jul 24, 2022 •

edited

Loading

du82 commented Jul 24, 2022

flexsurfer commented Jul 25, 2022

yqrashawn commented Jul 25, 2022

flexsurfer commented Jul 25, 2022

yqrashawn commented Jul 25, 2022 •

edited

Loading

jakubgs left a comment

yqrashawn commented Aug 1, 2022

yqrashawn commented Aug 1, 2022

status-im-auto commented Aug 1, 2022

Class TestRestoreOneDeviceMerged:

Class TestOneToOneChatMultipleSharedDevices:

Class TestContactBlockMigrateKeycardMultipleSharedDevices:

Class TestPairingSyncMultipleDevicesMerged:

Class TestOneToOneChatMultipleSharedDevices:

Class TestGroupChatMultipleDeviceMerged:

Class TestOnboardingOneDeviceMerged:

Class TestWalletManagementDeviceMerged:

Class TestPublicChatBrowserOneDeviceMerged:

Class TestCommandsMultipleDevicesMerged:

Class TestRestoreOneDeviceMerged:

Class TestEnsStickersMultipleDevicesMerged:

Class TestSendTxDeviceMerged:

Class TestKeycardTxOneDeviceMerged:

Class TestPublicChatMultipleDeviceMerged:

qoqobolo commented Aug 1, 2022

flexsurfer left a comment

yqrashawn commented Aug 2, 2022

flexsurfer left a comment

yqrashawn commented Aug 2, 2022

feat: lottie splash screen #13714

feat: lottie splash screen #13714

Conversation

yqrashawn commented Jul 23, 2022 • edited Loading

Summary

Review notes

Testing notes

Platforms

Steps to test

status-github-bot bot commented Jul 23, 2022

status-im-auto commented Jul 23, 2022 • edited Loading

Jenkins Builds

yqrashawn commented Jul 24, 2022 • edited Loading

du82 commented Jul 24, 2022

flexsurfer commented Jul 25, 2022

yqrashawn commented Jul 25, 2022

flexsurfer commented Jul 25, 2022

yqrashawn commented Jul 25, 2022 • edited Loading

jakubgs left a comment

Choose a reason for hiding this comment

yqrashawn commented Aug 1, 2022

yqrashawn commented Aug 1, 2022

status-im-auto commented Aug 1, 2022

98% of end-end tests have passed

Failed tests (2)

Class TestRestoreOneDeviceMerged:

Class TestOneToOneChatMultipleSharedDevices:

Passed tests (85)

Class TestContactBlockMigrateKeycardMultipleSharedDevices:

Class TestPairingSyncMultipleDevicesMerged:

Class TestOneToOneChatMultipleSharedDevices:

Class TestGroupChatMultipleDeviceMerged:

Class TestOnboardingOneDeviceMerged:

Class TestWalletManagementDeviceMerged:

Class TestPublicChatBrowserOneDeviceMerged:

Class TestCommandsMultipleDevicesMerged:

Class TestRestoreOneDeviceMerged:

Class TestEnsStickersMultipleDevicesMerged:

Class TestSendTxDeviceMerged:

Class TestKeycardTxOneDeviceMerged:

Class TestPublicChatMultipleDeviceMerged:

qoqobolo commented Aug 1, 2022

flexsurfer left a comment

Choose a reason for hiding this comment

yqrashawn commented Aug 2, 2022

flexsurfer left a comment

Choose a reason for hiding this comment

yqrashawn commented Aug 2, 2022

yqrashawn commented Jul 23, 2022 •

edited

Loading

status-im-auto commented Jul 23, 2022 •

edited

Loading

yqrashawn commented Jul 24, 2022 •

edited

Loading

yqrashawn commented Jul 25, 2022 •

edited

Loading