Switcher and Bottom Tabs Animations and UI Performance Improvements #13470
Conversation
Jenkins BuildsClick to see older builds (91)
|
Not sure why the file is not found on the Jenkins build, working great locally. UPD: fixed (nix configuration files needed to be updated) |
Parveshdhull
force-pushed
the
fix/use-reanimated-v2-for-switcher-animations
branch
6 times, most recently
from
81eb61c
to
025f0f8
Compare
Parveshdhull
force-pushed
the
fix/use-reanimated-v2-for-switcher-animations
branch
2 times, most recently
from
38b2262
to
c5fce27
Compare
Parveshdhull
changed the title
Parveshdhull
force-pushed
the
fix/use-reanimated-v2-for-switcher-animations
branch
from
c5fce27
to
646f01d
Compare
|
I will work on polishing UI and animations in the same PR because merging in the current state feels a little broken. I will ping for testing and review later once PR will be ready. |
Parveshdhull
changed the title
Parveshdhull
force-pushed
the
fix/use-reanimated-v2-for-switcher-animations
branch
2 times, most recently
from
790ee43
to
27495f2
Compare
Parveshdhull
force-pushed
the
fix/use-reanimated-v2-for-switcher-animations
branch
3 times, most recently
from
daddb3e
to
d37d501
Compare
src/quo2/reanimated.cljs
Outdated
| (into {}))) | ||
|
|
||
| ;; Worklets | ||
| (def worklet-factory (js/require "../js/worklet_factory.js")) |
There was a problem hiding this comment.
can it be in :require ? ["../js/worklet_factory.js" :as worklet-factory]
There was a problem hiding this comment.
btw why it's not inside src folder?
There was a problem hiding this comment.
can it be in :require ? ["../js/worklet_factory.js" :as worklet-factory]
js directive are not working with :require #13452 (comment)
btw why it's not inside src folder?
moved to src
| ;; kebab-case styles are not working for worklets | ||
| ;; so first convert kebab case styles into camel case styles | ||
| (defn apply-animations-to-style [animations style] | ||
| (let [animations (map-keys kebab-case->camelCase animations) |
There was a problem hiding this comment.
could you elaborate why map-keys and kebab-case->camelCase
There was a problem hiding this comment.
Hi, I think kebab case only works with clojure due to reagent, but as worklets are inside js file which is directly processed by metro instead of shadow-cljs (due to js/require for directives) only camel case works there
| @@ -308,7 +308,7 @@ | |||
| "react-native-share" react-native-share | |||
| "@react-native-community/async-storage" async-storage | |||
| "react-native-svg" react-native-svg | |||
| "../js/worklet_factory.js" worklet-factory | |||
| "../src/js/worklet_factory.js" worklet-factory | |||
| @@ -47,7 +47,7 @@ | |||
| (into {}))) | |||
|
|
|||
| ;; Worklets | |||
| (def worklet-factory (js/require "../js/worklet_factory.js")) | |||
| (def worklet-factory (js/require "../src/js/worklet_factory.js")) | |||
There was a problem hiding this comment.
For some reason js/require is only working with ../src/js/worklet_factory.js
Github video player is unable to play this video, only playing locally
Parveshdhull
force-pushed
the
fix/use-reanimated-v2-for-switcher-animations
branch
from
90ab685
to
e0ef82f
Compare
|
Hey @Parveshdhull! Thanks for all this work you've done! ISSUE 1: The switcher button has become white in dark mode when activeDo we consider this a regression? Asking, since it works differently in the develop. Steps:
|
|
Hi @qoqobolo, Thanks for testing the PR and finding the issue. |
100% of end-end tests have passedPassed tests (84)Click to expand
|
|
@Parveshdhull thanks, PR can be merged |
Parveshdhull
force-pushed
the
fix/use-reanimated-v2-for-switcher-animations
branch
2 times, most recently
from
eb41e56
to
d5caec3
Compare
- Migrated Switcher animations to Reanimated V2 - Added bottom tabs & Stacks Animations - Improved bottom tabs, tab changing performance - Polished android & IOS UI
Parveshdhull
force-pushed
the
fix/use-reanimated-v2-for-switcher-animations
branch
from
d5caec3
to
1047c26
Compare
fixes #13452
fixes #13440
Summary
Testing
Please test PR for any regressions.
Also, PR includes a new source folder(js) for
worklets, please let me know if this is creating an issue for the nightly build. (No need for retesting, just let me know if the nightly build is failing)status: ready