Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use a default pairing password Keycard #12811

Merged
merged 1 commit into from
Nov 16, 2021
Merged

use a default pairing password Keycard #12811

merged 1 commit into from
Nov 16, 2021

Conversation

bitgamma
Copy link
Member

@bitgamma bitgamma commented Nov 11, 2021 •
edited
Loading

Closes #12685

The new behaviour is:

  1. when creating a new Keycard account with empty/factory reset card, the pairing password will be KeycardDefaultPairing
  2. when recovering a Keycard account or restoring pairing in any way, the KeycardDefaultPairing password will be automatically tested before prompting the user for a pairing password. If it succeeds, the user skips the pairing step automatically, otherwise proceeds as before.

@status-im-auto
Copy link
Member

status-im-auto commented Nov 11, 2021 •
edited
Loading

Jenkins Builds

Click to see older builds (23)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
❌ 8d5901b #1 2021-11-11 15:19:39 ~12 min ios 📄log
✔️ 8d5901b #1 2021-11-11 15:26:37 ~19 min android-e2e 📦apk 📲
✔️ 8d5901b #1 2021-11-11 15:31:38 ~25 min android 📦apk 📲
❌ 0554c0d #2 2021-11-12 06:14:45 ~6 min ios 📄log
✔️ 0554c0d #2 2021-11-12 06:22:05 ~13 min android-e2e 📦apk 📲
❌ 0554c0d #3 2021-11-12 06:24:53 ~4 min ios 📄log
✔️ 0554c0d #2 2021-11-12 06:27:51 ~19 min android 📦apk 📲
❌ 96c79d2 #4 2021-11-12 07:27:50 ~6 min ios 📄log
✔️ 96c79d2 #3 2021-11-12 07:34:25 ~12 min android 📦apk 📲
✔️ 96c79d2 #3 2021-11-12 07:35:16 ~13 min android-e2e 📦apk 📲
❌ 96c79d2 #5 2021-11-15 08:42:49 ~10 min ios 📄log
✔️ 94b3475 #4 2021-11-15 09:11:17 ~13 min android 📦apk 📲
✔️ 94b3475 #4 2021-11-15 09:12:26 ~14 min android-e2e 📦apk 📲
✔️ 94b3475 #6 2021-11-15 09:16:33 ~18 min ios 📦ipa 📲
✔️ 6a6611e #7 2021-11-15 09:47:19 ~18 min ios 📦ipa 📲
✔️ 6a6611e #5 2021-11-15 09:47:22 ~18 min android 📦apk 📲
✔️ 6a6611e #5 2021-11-15 09:48:08 ~19 min android-e2e 📦apk 📲
✔️ 0757d91 #8 2021-11-15 10:59:09 ~16 min ios 📦ipa 📲
✔️ 0757d91 #6 2021-11-15 10:59:24 ~16 min android 📦apk 📲
✔️ 0757d91 #6 2021-11-15 10:59:43 ~17 min android-e2e 📦apk 📲
✖️ ed2b9e6 #7 2021-11-15 12:28:20 ~16 min android-e2e 📦apk 📲
✖️ ed2b9e6 #7 2021-11-15 12:32:17 ~20 min android 📦apk 📲
✖️ ed2b9e6 #9 2021-11-15 13:05:13 ~53 min ios 📦ipa 📲
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ c22c8e3 #8 2021-11-15 12:59:02 ~28 min android-e2e 📦apk 📲
✔️ c22c8e3 #8 2021-11-15 13:04:43 ~34 min android 📦apk 📲
✔️ c22c8e3 #12 2021-11-15 14:31:48 ~17 min ios 📦ipa 📲
✔️ 5c0e4f6 #9 2021-11-16 05:45:24 ~15 min android-e2e 📦apk 📲
✔️ 5c0e4f6 #9 2021-11-16 05:46:40 ~16 min android 📦apk 📲
✔️ 5c0e4f6 #13 2021-11-16 05:48:39 ~18 min ios 📦ipa 📲

@bitgamma bitgamma changed the title [WIP] use a default pairing password Keycard use a default pairing password Keycard Nov 15, 2021
flexsurfer
flexsurfer approved these changes Nov 15, 2021
View reviewed changes
src/status_im/keycard/common.cljs Outdated
(let [paired-on (utils.datetime/timestamp)
pairings (-> (get-in db [:keycard :pairings])
(assoc instance-uid {:pairing pairing :paired-on paired-on}))]
(fx/merge
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge is redundant here

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can just return a map

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed, thanks!

@qoqobolo qoqobolo self-assigned this Nov 15, 2021
@qoqobolo
Copy link
Contributor

@bitgamma thanks for the PR!

ISSUE 1: Onboarding flow gets stuck at the creating passcode step

When trying to create/recover a Keycard account the onboarding process stops after confirming the passcode.

Steps:

  1. Install Status
  2. Generate keys > Choose a name > Choose Keycard > Begin setup
  3. Create and confirm a passcode

OS: Android, iOS

IMG_0967.MP4

@status-im-auto
Copy link
Member

80% of end-end tests have passed

Total executed tests: 69
Failed tests: 14
Passed tests: 55

IDs of failed tests: 6291,5314,5350,5786,6316,6289,5384,5308,6228,6253,6263,5346,5381,6293

Failed tests (14)

Click to expand
  • Rerun tests

    • 1. test_keycard_can_see_all_transactions_in_history, id: 6291

    Device 1: Find 'WalletButton' by 'xpath': `//*[contains(@content-desc,'tab, 3 out of 5')]`
    Device 1: Find 'TransactionHistoryButton' by 'accessibility id': `History-item-button`

    Device 1: TransactionHistoryButton by accessibility id: `History-item-button` is not found on the screen

    Device sessions

    2. test_can_see_balance_and_all_transactions_history_on_cellular, id: 5314

    Device 1: Swiping up
    Device 1: Find 'TransactionHistoryButton' by 'accessibility id': `History-item-button`

    Device 1: TransactionHistoryButton by accessibility id: `History-item-button` is not found on the screen

    Device sessions

    3. test_send_token_with_7_decimals, id: 5350

    Device 1: Finding '0.0008671 ADI' transaction for 'Ethereum account'
    Device 1: Getting account: 'Ethereum account'

    Device 1: 'AccountElementButton' by xpath:'//*[@content-desc='accountcardEthereum account']' not found on the screen

    Device sessions

    4. test_block_user_from_public_chat, id: 5786

    Device 1: Looking for a message by text: Before block from 2
    Device 1: Find 'ChatElementByText' by 'xpath': `//*[starts-with(@text,'Before block from 2')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']`

    Device 1: ChatElementByText by xpath:`//*[starts-with(@text,'Before block from 2')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen

    Device sessions

    5. test_send_audio_message_with_push_notification_check, id: 6316

    Device 1: Find 'Button' by 'accessibility id': `start-stop-audio-recording-button`
    Device 1: Tap on found: Button

    Device 1: Exceeded 2 mins limit of recording time.; also Unexpected Alert is shown: 'Maximum recording time reached'

    Device sessions

    6. test_keycard_send_eth_from_wallet_to_address, id: 6289

    Device 1: Finding '0.0015112047 ETH' transaction for 'Ethereum account'
    Device 1: Getting account: 'Ethereum account'

    Device 1: 'AccountElementButton' by xpath:'//*[@content-desc='accountcardEthereum account']' not found on the screen

    Device sessions

    7. test_open_transaction_on_etherscan_copy_tx_hash, id: 5384

    # STEP: Open transaction on etherscan
    Device 1: Find 'TransactionHistoryButton' by 'accessibility id': `History-item-button`

    Device 1: TransactionHistoryButton by accessibility id: `History-item-button` is not found on the screen

    Device sessions

    8. test_send_eth_from_wallet_to_address_incorrect_password, id: 5308

    Device 1: Finding '0.0015111638 ETH' transaction for 'Ethereum account'
    Device 1: Getting account: 'Ethereum account'

    Device 1: 'AccountElementButton' by xpath:'//*[@content-desc='accountcardEthereum account']' not found on the screen

    Device sessions

    9. test_mobile_data_usage_complex_settings, id: 6228

    Device 1: Find 'Button' by 'xpath': `//*[@text="Use mobile data"]/following-sibling::android.widget.Switch[1]`
    Device 1: Find 'Button' by 'xpath': `//*[@text="Ask me when on mobile network"]/following-sibling::android.widget.Switch[1]`

    Chat history was not fetched with mobile data fetching ON

    Device sessions

    10. test_send_eth_in_1_1_chat_transaction_push, id: 6253

    Device 1: Finding '0.0015105251 ETH' transaction for 'Ethereum account'
    Device 1: Getting account: 'Ethereum account'

    Device 1: TransactionHistoryButton by accessibility id: `History-item-button` is not found on the screen

    Device sessions

    11. test_request_and_receive_stt_in_1_1_chat_offline, id: 6263

    Device 2: Finding '0.0015105836 STT' transaction for 'Ethereum account'
    Device 2: Getting account: 'Ethereum account'

    Device 2: TransactionHistoryButton by accessibility id: `History-item-button` is not found on the screen

    Device sessions

    12. test_collectible_from_wallet, id: 5346

    Device 1: Tap on found: Button
    Device 1: Find 'Button' by 'xpath': `//*[@text="Collectibles"]`

    Device 1: Button by xpath: `//*[@text="Collectibles"]` is not found on the screen

    Device sessions

    13. test_user_can_see_collectibles_on_rinkeby_after_account_recovering, id: 5381

    Device 1: Tap on found: Button
    Device 1: Find 'Button' by 'xpath': `//*[@text="Collectibles"]`

    Device 1: Button by xpath: `//*[@text="Collectibles"]` is not found on the screen

    Device sessions

    14. test_keycard_send_eth_in_1_1_chat, id: 6293

    Device 1: Finding '0.0015104849 ETH' transaction for 'Ethereum account'
    Device 1: Getting account: 'Ethereum account'

    Device 1: TransactionHistoryButton by accessibility id: `History-item-button` is not found on the screen

    Device sessions

    Passed tests (55)

    Click to expand

    1. test_image_in_one_to_one_send_save_reply_timeline, id: 6305
    Device sessions

    2. test_add_account_to_multiaccount_instance_generate_new, id: 6224
    Device sessions

    3. test_can_add_existing_ens_on_mainnet, id: 5502
    Device sessions

    4. test_sign_message_and_2tx_in_batch_and_transactions_filters_from_daap, id: 5342
    Device sessions

    5. test_add_and_delete_watch_only_account_to_multiaccount_instance, id: 6244
    Device sessions

    6. test_open_blocked_secure_not_secure_inlalid_offline_urls, id: 6210
    Device sessions

    7. test_open_public_chat_using_deep_link, id: 5396
    Device sessions

    8. test_offline_add_new_group_chat_member, id: 3998
    Device sessions

    9. test_send_non_english_message_to_newly_added_contact_on_different_networks, id: 5315
    Device sessions

    10. test_insufficient_funds_wallet_positive_balance, id: 5412
    Device sessions

    11. test_delete_close_all_tabs, id: 5390
    Device sessions

    12. test_create_new_group_chat_messaging_pn_delivered, id: 3994
    Device sessions

    13. test_delete_chats_via_delete_button_rejoin, id: 5387
    Device sessions

    14. test_send_transaction_set_recipient_options, id: 6328
    Device sessions

    15. test_keycard_sign_message_and_transactions_from_daap, id: 6251
    Device sessions

    16. test_recover_account_from_new_user_seedphrase, id: 6296
    Device sessions

    17. test_keycard_can_recover_keycard_account_card_pairing, id: 5758
    Device sessions

    18. test_redirect_to_public_chat_tapping_tag_message_fetch_more_history, id: 5675
    Device sessions

    19. test_restore_account_migrate_multiaccount_to_keycard, id: 6645
    Device sessions

    20. test_edit_delete_message_in_one_to_one_and_public_chats, id: 695843
    Device sessions

    21. test_ens_mentions_pn_and_nickname_in_public_and_1_1_chats, id: 6226
    Device sessions

    22. test_keycard_create_login_restore_unlock_same_seed, id: 5689
    Device sessions

    23. test_add_account_to_wallet_private_key_and_seed_phrase, id: 6272
    Device sessions

    24. test_offline_is_shown_messaging_1_1_chat_sent_delivered, id: 5310
    Device sessions

    25. test_pair_devices_sync_one_to_one_contacts_nicknames_public_chat, id: 5762
    Device sessions

    26. test_long_press_to_delete_chat, id: 5319
    Device sessions

    27. test_copy_and_paste_messages, id: 5317
    Device sessions

    28. test_unread_messages_counter_public_chat, id: 5360
    Device sessions

    29. test_start_chat_with_ens_mention_in_one_to_one, id: 5403
    Device sessions

    30. test_decline_transactions_in_1_1_chat_push_notification_changing_state, id: 6265
    Device sessions

    31. test_install_pack_and_send_sticker, id: 5782
    Device sessions

    32. test_switch_users_special_char_password_and_add_new_account_logcat, id: 5356
    Device sessions

    33. test_manage_assets, id: 5341
    Device sessions

    34. test_browser_managing_bookmarks, id: 6633
    Device sessions

    35. test_open_chat_by_pasting_chat_key_check_invalid_chat_key_cases, id: 5304
    Device sessions

    36. test_request_stt_from_daap, id: 5309
    Device sessions

    37. test_can_use_purchased_stickers_on_recovered_account, id: 5783
    Device sessions

    38. test_dapps_permissions, id: 5738
    Device sessions

    39. test_account_recovery_with_uppercase_whitespaces_seed_phrase_special_char_passw_logcat, id: 5394
    Device sessions

    40. test_send_eth_to_ens_in_chat, id: 6279
    Device sessions

    41. test_share_copy_contact_code_and_wallet_address, id: 5323
    Device sessions

    42. test_wallet_set_up, id: 5335
    Device sessions

    43. test_send_transaction_with_custom_token, id: 6208
    Device sessions

    44. test_home_view, id: 5379
    Device sessions

    45. test_logcat_backup_recovery_phrase, id: 5419
    Device sessions

    46. test_set_profile_picture, id: 6646
    Device sessions

    47. test_add_and_remove_mention_contact_with_nickname_from_public_chat, id: 5332
    Device sessions

    48. test_keycard_request_stt_from_daap, id: 6249
    Device sessions

    49. test_restore_account_from_mnemonic_to_keycard, id: 6240
    Device sessions

    50. test_pass_phrase_validation, id: 5363
    Device sessions

    51. test_send_and_open_links_with_previews, id: 5373
    Device sessions

    52. test_reactions_to_message_in_chats, id: 6315
    Device sessions

    53. test_fetching_balance_after_offline, id: 6237
    Device sessions

    54. test_push_notification_1_1_chat_no_pn_activity_center, id: 6283
    Device sessions

    55. test_public_chat_messaging_emojis_timestamps, id: 5313
    Device sessions

    @bitgamma
    Copy link
    Member Author

    @qoqobolo thanks for testing it! Sorry about that bug, somehow I hadn't seen it. It is fixed now!

    @qoqobolo
    Copy link
    Contributor

    qoqobolo commented Nov 15, 2021 •
    edited
    Loading

    @bitgamma thank you! Everything is fine now.
    PR is tested and can be merged (failed e2e are not related to PR).

    @bitgamma bitgamma merged commit 4349f26 into develop Nov 16, 2021
    @bitgamma bitgamma deleted the feature/12685 branch November 16, 2021 05:31
    @bitgamma bitgamma mentioned this pull request Dec 10, 2021
    Merged
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @flexsurfer flexsurfer flexsurfer approved these changes

    Assignees

    @bitgamma bitgamma

    @qoqobolo qoqobolo

    Labels
    request-manual-qa Tested - OK
    Projects
    No open projects
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    Make keycard pairing password a default one
    4 participants
    @bitgamma @status-im-auto @qoqobolo @flexsurfer