Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Binance Smart chain as main network #12760

Closed
churik opened this issue Oct 28, 2021 · 4 comments · Fixed by #12809
Closed

Add Binance Smart chain as main network #12760

churik opened this issue Oct 28, 2021 · 4 comments · Fixed by #12809
Assignees
Labels
feature feature requests

Comments

@churik
Copy link
Member

churik commented Oct 28, 2021

Bug Report

Problem

Requested by users. Currently can be added as custom network, but have ETH as main currency and transaction history can't be loaded

Expected behavior

  1. Can see correct balance of BNB
  2. Can see transaction history
  3. Can easily switch to Binance smart chain as it will be in the list of Main networks

Actual behavior

Monosnap 2021-10-28 12-24-11 png 2021-10-28 12-26-57

IMAGE 2021-10-28 12:28:41

Reproduction

  1. Open Status
  2. Add custom network with params:
    URL: https://bsc-dataseed.binance.org/
    ID: 56

Additional Information

  • Status version: release 1.17
  • Operating System: Android, iOS
@churik churik added the feature feature requests label Oct 28, 2021
@churik churik changed the title Add Binance Smart chain in main networks Add Binance Smart chain as main network Oct 28, 2021
@churik
Copy link
Member Author

churik commented Nov 3, 2021

Basically, for any custom RPC chain we missing some optional params, which are using in MetaMask for instance (currency symbol, block explorer)
Monosnap 2021-11-03 16-31-36
I believe it may be related to #12777 also, as we don't have blockcain explorer added on these chains (just an assumption)

Anyway, if custom RPC can work as it works in metamsk - that would be just awesome.

@qoqobolo
Copy link
Contributor

qoqobolo commented Nov 3, 2021

Additional related issue that was reported from our user:

Cannot connect to Dapps in binance smart chain

Steps:

  1. Switch to Binance smart chain
  2. Open browser and navigate to some of the following DApps:
  • Farm.rabbitfinance.io
  • pancakebunny.finance
  • pancakeswap.finance
  • App.alpacafinance.org
  • www.tranchess.com
  1. Allow connection to the wallet

Expected behavior: can connect and use DApp normally
Actual behavior: DApp and Status browser tabs freeze

OS: Android, iOS
Status version: 1.17, Nightly 3/11

@flexsurfer
Copy link
Member

@qoqobolo dapps are fixed here #12791

@flexsurfer
Copy link
Member

@churik we don't use block explorers that's why history doesn't work, dunno might be @rasom could comment what we can do about that ,but most likely it depends on RPC if it supports methods we need for history or not

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature feature requests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants
@churik @flexsurfer @qoqobolo and others