Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore_: move/rename files messing generation #5897

Merged
merged 4 commits into from
Sep 30, 2024

Conversation

igor-sirotin
Copy link
Collaborator

@igor-sirotin igor-sirotin commented Sep 30, 2024

  1. Moved generate_handlers to ./cmd.

    • Otherwise it's not detected by go list ./.... And I don't want to add custom instructions for one case.
    • And it makes sense to be there, same as ./cmd/library.
  2. Rename protocol/sqlite/migrations.go

    • migrations.go is used for generated files, which we gitignore. Just renamed it to avoid exclusions.

Required for:

@status-im-auto
Copy link
Member

status-im-auto commented Sep 30, 2024

Jenkins Builds

Click to see older builds (5)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 7ecc828 #1 2024-09-30 16:18:21 ~2 min tests-rpc 📄log
✔️ 7ecc828 #1 2024-09-30 16:20:26 ~4 min linux 📦zip
✔️ 7ecc828 #1 2024-09-30 16:20:35 ~5 min ios 📦zip
✔️ 7ecc828 #1 2024-09-30 16:20:51 ~5 min android 📦aar
✔️ 7ecc828 #1 2024-09-30 16:48:21 ~32 min tests 📄log
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 144cf07 #2 2024-09-30 16:59:45 ~1 min android 📦aar
✖️ 144cf07 #2 2024-09-30 17:00:15 ~2 min tests-rpc 📄log
✔️ 144cf07 #2 2024-09-30 17:01:36 ~3 min ios 📦zip
✔️ 144cf07 #2 2024-09-30 17:01:46 ~3 min linux 📦zip
✔️ 144cf07 #2 2024-09-30 17:31:28 ~33 min tests 📄log
✔️ 3316633 #3 2024-09-30 17:05:03 ~1 min android 📦aar
✔️ 3316633 #3 2024-09-30 17:05:44 ~2 min linux 📦zip
✔️ 3316633 #3 2024-09-30 17:06:13 ~2 min tests-rpc 📄log
✔️ 3316633 #3 2024-09-30 17:06:48 ~3 min ios 📦zip
✔️ 3316633 #3 2024-09-30 18:02:58 ~31 min tests 📄log

@codecov-commenter
Copy link

codecov-commenter commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (develop@9eb2d97). Learn more about missing BASE report.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #5897   +/-   ##
==========================================
  Coverage           ?   46.05%           
==========================================
  Files              ?      888           
  Lines              ?   157379           
  Branches           ?        0           
==========================================
  Hits               ?    72482           
  Misses             ?    76576           
  Partials           ?     8321           
Flag Coverage Δ
functional 11.36% <ø> (?)
unit 45.63% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
protocol/sqlite/prepare_migrations.go 100.00% <ø> (ø)

protocol/sqlite/prepare.go Outdated Show resolved Hide resolved
@igor-sirotin igor-sirotin merged commit 031b534 into develop Sep 30, 2024
12 checks passed
@igor-sirotin igor-sirotin deleted the chore/move-rename-files-messing-generation branch September 30, 2024 18:19
adklempner pushed a commit that referenced this pull request Oct 1, 2024
* refactor_: rename migrations file

* refactor_: move generate_handlers to cmd

* fix_: makefile generate_handlers path
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants