-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix_: Flaky TestBackupKeypairs test #5811
Conversation
Signed-off-by: Mohamed Javid <[email protected]>
Jenkins BuildsClick to see older builds (5)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for a quick fix!
I'll keep #4576 opened, the original issue might still be there.
Signed-off-by: Mohamed Javid <[email protected]>
e47cff0
to
f14f35a
Compare
❌ 2 Tests Failed:
View the top 2 failed tests by shortest run time
To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR fixes the flaky
TestBackupKeypairs
test.The flakiness is due to the order in which the backup is processed. The test expects the profile keypair addresses first but sometimes, the non-profile keypair is processed before the profile keypair. This PR updates the test to ensure the expected addresses are equal result addresses irrespective of the order.