fix(community)_: fix pure readonly channels not respecting the right roles #5513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins Builds
|
osmaczko
approved these changes
Jul 12, 2024
| } | ||
|
|
||
| _, err = s.bob.SendChatMessage(context.Background(), msg) | ||
| s.Require().Error(err) |
There was a problem hiding this comment.
Would it be possible to check exact error here?
There was a problem hiding this comment.
That was a good tip, turns out I was passing the wrong chatID, so the error was unknown chat 🙈
I'm fixing it and making it test the error
|
FYI, I ran the test a 1000 times: |
jrainville
force-pushed
the
fix/re-only-channels-members-marked-as-posters
branch
from
4841803
to
dd77220
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes status-im/status-desktop#15547
The problem was that we used
channelEncryptedto know if we should use all the community members or the given members by the control node.However, pure read-only channel (for example announcements) are permissions, but not encrypted, since everyone still has access to read them.
The solution is to add
channelHasPermissionsand use that one instead in the hydrate and dehydrate functions.I also added a test to validate the behaviour. It seems like we never tested pure read-only channels before.