[CHERRY PICK] fix_: fill missing community tokens in controlled communities (#5154) #5188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needed for status-im/status-desktop#14679 On app start, fills controlled communities with missing deployed community tokens if there are.
kounkou
reviewed
May 21, 2024
| @@ -481,6 +481,11 @@ func (m *Manager) Start() error { | |||
| if m.ownerVerifier != nil { | |||
| m.runOwnerVerificationLoop() | |||
| } | |||
|
|
|||
| go func() { | |||
| _ = m.fillMissingCommunityTokens() | |||
There was a problem hiding this comment.
Just wondering if it makes sense to log something in case of error since fillMissingCommunityTokens returns an error? Did you maybe anticipate this might be too verbose?
There was a problem hiding this comment.
I do all the logs directly in fillMissingCommunityTokens. I could add an additional log here, but it would just repeat the error and lack the additional context.
MishkaRogachev
approved these changes
May 21, 2024
kounkou
reviewed
May 21, 2024
| @@ -513,6 +518,61 @@ func (m *Manager) runENSVerificationLoop() { | |||
| }() | |||
| } | |||
|
|
|||
| // This function is mostly a way to fix any community that is missing tokens in its description | |||
| func (m *Manager) fillMissingCommunityTokens() error { | |||
There was a problem hiding this comment.
To me, this function looks hard to predict knowing that it's called in different go routines, but seems ok to me as well. I thought about using go channels as well, but it would require some deeper analysis.
kounkou
approved these changes
May 21, 2024
chaitanyaprem
pushed a commit
that referenced
this pull request
May 28, 2024
…#5188) Needed for status-im/status-desktop#14679 On app start, fills controlled communities with missing deployed community tokens if there are.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick of #5154
Needed for status-im/status-desktop#14679
On app start, fills controlled communities with missing deployed community tokens if there are.