fix(permissions): private permissions shouldn't affect the check #5116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrainville
changed the title
Jenkins Builds
|
mprakhov
approved these changes
May 7, 2024
ajayesivan
approved these changes
May 8, 2024
jrainville
force-pushed
the
fix/hide-permission-disables-the-perm
branch
from
e906b4e
to
efea842
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes status-im/status-desktop#14608
The permission check was incorrectly deleting the response to a permission that was private.
What this caused is that the permission check was completely ignored, which meant that the channel would be open to everyone.
@ajayesivan I saw that you were the one that added those lines. The way we hide the permissions is on the UI side for Desktop.
Otherwise, you can try to do it on the status-go side, but it would need to be only when passing the community to the front-end, though that's a bit harder.
Either way, doing it during the CheckPermissions is not the right way, since it makes it so that we completely ignore the permission.