Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add node config RuntimeLogLevel option #4667

Merged
merged 1 commit into from
Feb 2, 2024
Merged

Conversation

kounkou
Copy link
Contributor

@kounkou kounkou commented Feb 2, 2024

Description

Closes status-im/status-desktop#13139

linked to status-im/status-desktop#13309

Previously it was not possible to change the state of the Debug toggle. This is because the code forced the setting the default value, ignoring the database setup, hence always setting the DEBUG as LogLevel.

This PR adds :

  • A RuntimeLogLevel to enable setting ephemeral loggig strategy on status-go

@status-im-auto
Copy link
Member

status-im-auto commented Feb 2, 2024

Jenkins Builds

Click to see older builds (14)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 411a6c7 #1 2024-02-02 06:28:01 ~3 min linux 📦zip
✔️ 411a6c7 #1 2024-02-02 06:30:04 ~5 min android 📦aar
✔️ 411a6c7 #1 2024-02-02 06:30:33 ~6 min ios 📦zip
✔️ 411a6c7 #1 2024-02-02 07:02:55 ~38 min tests 📄log
✔️ daadf58 #2 2024-02-02 15:14:48 ~1 min linux 📦zip
✔️ daadf58 #2 2024-02-02 15:15:03 ~1 min android 📦aar
✔️ daadf58 #2 2024-02-02 15:18:03 ~4 min ios 📦zip
✖️ daadf58 #2 2024-02-02 15:18:40 ~5 min tests 📄log
✔️ ff54ba1 #3 2024-02-02 15:31:51 ~1 min linux 📦zip
✔️ ff54ba1 #3 2024-02-02 15:32:21 ~1 min android 📦aar
✔️ ff54ba1 #3 2024-02-02 15:33:34 ~3 min ios 📦zip
✖️ ff54ba1 #3 2024-02-02 15:33:50 ~3 min tests 📄log
✖️ ff54ba1 #4 2024-02-02 15:38:32 ~3 min tests 📄log
✖️ ff54ba1 #5 2024-02-02 15:47:45 ~3 min tests 📄log
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 674621f #4 2024-02-02 16:13:16 ~2 min ios 📦zip
✔️ 674621f #4 2024-02-02 16:14:18 ~3 min linux 📦zip
✔️ 674621f #4 2024-02-02 16:15:57 ~5 min android 📦aar
✔️ 674621f #6 2024-02-02 16:48:36 ~38 min tests 📄log
✔️ 2d19a8d #5 2024-02-02 19:57:14 ~1 min linux 📦zip
✔️ 2d19a8d #5 2024-02-02 19:57:42 ~1 min android 📦aar
✔️ 2d19a8d #5 2024-02-02 19:58:55 ~2 min ios 📦zip
✔️ 2d19a8d #7 2024-02-02 20:32:16 ~36 min tests 📄log

Copy link
Collaborator

@igor-sirotin igor-sirotin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the test! 💪

api/geth_backend.go Outdated Show resolved Hide resolved
params/config.go Outdated Show resolved Hide resolved
@igor-sirotin igor-sirotin changed the title fix(settings): It's not possible to switch the log level fix: add node config RuntimeLogLevel option Feb 2, 2024
@kounkou kounkou force-pushed the fix-debug-log-setting branch 2 times, most recently from daadf58 to ff54ba1 Compare February 2, 2024 15:30
Copy link
Collaborator

@igor-sirotin igor-sirotin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please wait for @osmaczko to review

Copy link
Contributor

@osmaczko osmaczko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm now

Closes #13139

Previously it was not possible to change the state of the Debug toggle.
This is because the code forced the setting the default value, ignoring
the database setup, hence always setting the DEBUG as LogLevel.

This PR adds :

- A RuntimeLogLevel to enable setting ephemeral loggig strategy on status-go
@kounkou kounkou merged commit 4584de3 into develop Feb 2, 2024
7 checks passed
@kounkou kounkou deleted the fix-debug-log-setting branch February 2, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

It's not possible to switch the log level
4 participants