Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix xgo invocation path after removal of env.sh #466

Merged
merged 1 commit into from
Nov 21, 2017
Merged

Conversation

divan
Copy link
Contributor

@divan divan commented Nov 21, 2017

This PR fixes invokation path for xgo tool, which left broken after the removal of env.sh helper script.

go get installs xgo into $GOPATH/bin directory, but currently Makefile looks for build/bin/xgo and files for fresh installations (users who did install it previously still have xgo in build/bin — that's why this problem went unnoticed)

Copy link
Contributor

@adambabik adambabik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@themue themue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adambabik adambabik merged commit 001a902 into develop Nov 21, 2017
@adambabik adambabik deleted the Makefile-xgo branch November 21, 2017 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants