jail: sendSignal handler #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adambabik
approved these changes
Sep 12, 2017
geth/jail/handlers.go
Outdated
| } | ||
|
|
||
| func makeSendMessageHandler(chatID string) func(call otto.FunctionCall) (response otto.Value) { | ||
| func makeSignalHandler(chatID string) func(call otto.FunctionCall) (response otto.Value) { |
There was a problem hiding this comment.
Signature can be shortened to:
func makeSignalHandler(chatID string) func(call otto.FunctionCall) otto.Value
rasom
force-pushed
the
feature/signal-event
branch
from
38dba07
to
d8d0517
Compare
tiabc
approved these changes
Sep 13, 2017
influx6
approved these changes
Sep 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of PR is to define one handler for all signals that can be sent from the jail in order to provide ability to add new kind of signal without making changes on
status-goside in future.