Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove downloading CHT from GH but embed it #270

Merged
merged 1 commit into from
Aug 25, 2017
Merged

Remove downloading CHT from GH but embed it #270

merged 1 commit into from
Aug 25, 2017

Conversation

adambabik
Copy link
Contributor

Changes:

  1. Remove downloading cht.json from GH,
  2. Remove CHT urls from config.

Important! We're leaving cht.json in GH for backward compatibility.

@adambabik adambabik requested a review from tiabc August 24, 2017 15:55
@tiabc tiabc requested a review from rgeraldes August 24, 2017 18:25
tiabc
tiabc approved these changes Aug 24, 2017
View reviewed changes
Copy link
Contributor

@tiabc tiabc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@rgeraldes please, squash and merge this PR tomorrow if everything is alright from your side (just one button on github).

@rgeraldes rgeraldes merged commit a4d2fdf into develop Aug 25, 2017
@rgeraldes rgeraldes deleted the feature/remove-chtjs-#267 branch August 25, 2017 09:57
@tiabc tiabc mentioned this pull request Sep 12, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiabc tiabc tiabc approved these changes

@rgeraldes rgeraldes rgeraldes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adambabik @tiabc @rgeraldes