Populate colorHash and colorId #2630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Checklist
|
Jenkins Builds
|
it returns color id for given pubkey
accounts displayed to users on login page should display colorHash and avatar fallback color (aka colorId)
osmaczko
force-pushed
the
feat/color-id-for-pubkey
branch
from
b8ca47f
to
2953096
Compare
Comment on lines
+284
to
+285
| colorHash, _ := colorhash.GenerateFor(string(acc.PublicKey.Bytes())) | ||
| colorID, _ := identityUtils.ToColorID(string(acc.PublicKey.Bytes())) |
There was a problem hiding this comment.
This is not bad per se, but i wonder if it would be a good idea to log an error in case any of these functions fail?
richard-ramos
approved these changes
Apr 8, 2022
iurimatias
approved these changes
Apr 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
required by: status-im/status-desktop#5424
accounts displayed to users on login page should display colorHash and
avatar fallback color (aka colorId)