remove ncli re
import/libpcre
dependency
#4208
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://nim-lang.org/docs/re.html is
In particular, https://github.com/nim-lang/Nim/blob/8ccde68f132be4dba330eb6ec50f4679e564efac/lib/wrappers/pcre.nim#L313-L329 pulls in
libpcre
using some system and configuration-dependent method:nimbus-eth
doesn't otherwise seem to use there
module, so this should remove the its last vestige, and keepnimbus-eth2
free of such dependency hazards.Otherwise, when running
ncli_db
without a supported version oflibpcre
(not a documented requirement):