don't verify BLS signatures in produced blocks #4184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnetheduck
reviewed
Sep 27, 2022
| if skip_randao_verification_bool: | ||
| {skipBlsValidation, skipRandaoVerification} | ||
| else: | ||
| {skipBlsValidation}, |
There was a problem hiding this comment.
we still need to validate the randao - unlike attestations et al, it hasn't gone through sig-checks at all (when coming from rest)
There was a problem hiding this comment.
This only avoids validating RANDAO when skip_randao_verification_bool, as before
There was a problem hiding this comment.
There was a problem hiding this comment.
also, I wonder if we should use a SigVerified cast instead which would generate better code
There was a problem hiding this comment.
This only avoids validating RANDAO when
skip_randao_verification_bool, as before
also, I wonder if we should use a
SigVerifiedcast instead which would generate better code
This was referenced Sep 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is time-consuming and, since blocks are verified anyway, superfluous.