allow custom configs in Gnosis binary #4134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running as Gnosis-chain binary the config was no longer adjustable. Restores loading custom configs when running as Gnosis-chain binary, as long as the following keys remain same: - SLOTS_PER_EPOCH=16 - SECONDS_PER_SLOT=5 - BASE_REWARD_FACTOR=25 - EPOCHS_PER_SYNC_COMMITTEE_PERIOD=512 This allows running the Gnosis-chain binary on custom test networks.
zah
reviewed
Sep 17, 2022
| proc getRuntimeConfig*(eth2Network: Option[string]): RuntimeConfig {.raises: [Defect, IOError].} = | ||
| checkNetworkParameterUse eth2Network | ||
| gnosisMetadata.cfg | ||
| proc getRuntimeConfig*( |
There was a problem hiding this comment.
This function should be removed now and all usages can be replaced with loadEth2Network(ethNetwork).cfg (or its moral equivalent).
In particular, the use of defaultRuntimeConfig is inappropriate due to the reasoning provided in #4121 (comment)
There was a problem hiding this comment.
Sounds more like a followup rather than a part of relaxing the Gnosis specific restrictions, but generally agree that this can now be done.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running as Gnosis-chain binary the config was no longer adjustable. Restores loading custom configs when running as Gnosis-chain binary, as long as the following keys remain same:
This allows running the Gnosis-chain binary on custom test networks.