Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more withState state -> forkyState #4112

Merged
merged 1 commit into from
Sep 13, 2022
Merged

more withState state -> forkyState #4112

merged 1 commit into from
Sep 13, 2022

Conversation

tersec
Copy link
Contributor

@tersec tersec commented Sep 12, 2022

Followup to #4026 (explanation), #4038 (first round of updates), and #4104 (second round of updates).

This completes the test suite, state_sim, block_sim, and nimbus_beacon_node in pure compilation-or-not terms, but to finish removing the state accessor, it needs to be audited for any remaining withState(state): foo(state) cases where they'll compile but not run correctly. Those work fine now, still, because the accessor template is still there.

Furthermore, some of the other make targets such as ncli_db will require a few more changes, with again an audit for the withState(state): foo(state) pattern in some contexts where it compiles successfully but to incorrect code.

This PR, on its own, is safe from such issues.

@github-actions
Copy link

Unit Test Results

       12 files  ±0       860 suites  ±0   59m 47s ⏱️ - 10m 46s
  1 982 tests ±0    1 835 ✔️ ±0  147 💤 ±0  0 ±0 
10 662 runs  ±0  10 472 ✔️ ±0  190 💤 ±0  0 ±0 

Results for commit 78f1281. ± Comparison against base commit 8be964a.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants