more withState
state
-> forkyState
#4112
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #4026 (explanation), #4038 (first round of updates), and #4104 (second round of updates).
This completes the test suite,
state_sim
,block_sim
, andnimbus_beacon_node
in pure compilation-or-not terms, but to finish removing thestate
accessor, it needs to be audited for any remainingwithState(state): foo(state)
cases where they'll compile but not run correctly. Those work fine now, still, because the accessor template is still there.Furthermore, some of the other
make
targets such asncli_db
will require a few more changes, with again an audit for thewithState(state): foo(state)
pattern in some contexts where it compiles successfully but to incorrect code.This PR, on its own, is safe from such issues.