harden exchangeTransitionConfiguration retries
#4095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`p.dataProvider` may become `nil` between individual attempts to exchange transition configuration with the EL. Harden by capturing the data provider on function start. Note that other functions are already hardened, or are unaffected. Only `close` transitions `p.dataProvider` to `nil`, and `close` is only called by the main deposits import sequence. During the deposits import, `close` is not called, so extra checks are not needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
p.dataProvidermay becomenilbetween individual attempts to exchange transition configuration with the EL. Harden by capturing the data provider on function start.Note that other functions are already hardened, or are unaffected. Only
closetransitionsp.dataProvidertonil, andcloseis only called by the main deposits import sequence. During the deposits import,closeis not called, so extra checks are not needed.