Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address #3624 #3934

Merged
merged 3 commits into from
Aug 6, 2022
Merged

Address #3624 #3934

merged 3 commits into from
Aug 6, 2022

Conversation

cheatfate
Copy link
Contributor

@github-actions
Copy link

github-actions bot commented Aug 3, 2022

Unit Test Results

       12 files  ±0       860 suites  ±0   1h 4m 43s ⏱️ - 9m 44s
  1 911 tests ±0    1 764 ✔️ ±0  147 💤 ±0  0 ±0 
10 341 runs  ±0  10 151 ✔️ ±0  190 💤 ±0  0 ±0 

Results for commit ddb3abb. ± Comparison against base commit 52b32c1.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@etan-status etan-status left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have not looked into the nim-http-utils changes thoroughly, but the submodule is updated to master so I guess those are already reviewed.

I did some checks re case-sensitive handling, and all seems correct ✅

RFC 2045

The type, subtype, and parameter names are not case sensitive. For
example, TEXT, Text, and TeXt are all equivalent top-level media
types. Parameter values are normally case sensitive, but sometimes
are interpreted in a case-insensitive fashion, depending on the
intended use. (For example, multipart boundaries are case-sensitive,
but the "access-type" parameter for message/External-body is not
case-sensitive.)

The new Chronos tests seem to cover the linked issue, so LGTM 👍

beacon_chain/rpc/rest_nimbus_api.nim Show resolved Hide resolved
@zah zah enabled auto-merge (squash) August 6, 2022 11:02
@zah zah merged commit fe5435e into unstable Aug 6, 2022
@zah zah deleted the address-content-type branch August 6, 2022 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants