Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enforce epoch alignment for --finalized-checkpoint-state/block #3858

Merged
merged 2 commits into from
Jul 12, 2022
Merged

enforce epoch alignment for --finalized-checkpoint-state/block #3858

merged 2 commits into from
Jul 12, 2022

Conversation

tersec
Copy link
Contributor

@tersec tersec commented Jul 12, 2022

No description provided.

etan-status
etan-status approved these changes Jul 12, 2022
View reviewed changes
Copy link
Contributor

@etan-status etan-status left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even better would be if this actually worked, but at least this describes the current implementation accurately.

beacon_chain/nimbus_beacon_node.nim Outdated Show resolved Hide resolved
@tersec
Copy link
Contributor Author

tersec commented Jul 12, 2022

Even better would be if this actually worked, but at least this describes the current implementation accurately.

Well, if one currently tries this, there's an assertion deep in the DAG, which isn't particularly informative to typical end-users.

@tersec tersec enabled auto-merge (squash) July 12, 2022 10:15
@tersec tersec merged commit 8a9e6ab into unstable Jul 12, 2022
@tersec tersec deleted the xWC branch July 12, 2022 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etan-status etan-status etan-status approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tersec @etan-status