Add the execution_optimistic flag to REST API responses.
#3780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zah
reviewed
Jun 20, 2022
| writer.endRecord() | ||
| stream.getOutput(seq[byte]) | ||
| except SerializationError: | ||
| default |
There was a problem hiding this comment.
SerializationError doesn't seem possible here, but why should this code return an empty response in case of an error instead of returning an error response?
zah
reviewed
Jun 20, 2022
| value.previous_duty_dependent_root) | ||
| writer.writeField("current_duty_dependent_root", | ||
| value.current_duty_dependent_root) | ||
| if value.optimistic.isSome(): |
There was a problem hiding this comment.
With the new Option support, you should be able to remove these procs, no?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
execution_optimisticflag to REST API responses.Eth-Consensus-VersionHTTP response header to/eth/v2/beacon/blocks/{block_id}and/eth/v2/debug/beacon/states/{state_id}endpoints./eth/v2/debug/beacon/headsendpoint.execution_optimisticto/eth/v1/eventsoutputs.is_optimisticto/eth/v1/node/syncingendpoint.