Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for the Sepolia network #3762

Merged
merged 4 commits into from
Jun 16, 2022
Merged

Add support for the Sepolia network #3762

merged 4 commits into from
Jun 16, 2022

Conversation

zah
Copy link
Contributor

@zah zah commented Jun 16, 2022 •
edited
Loading

Implements #3762

etan-status
etan-status approved these changes Jun 16, 2022
View reviewed changes
docs/the_nimbus_book/src/attestation-performance.md Outdated Show resolved Hide resolved
run-sepolia-beacon-node.sh Outdated Show resolved Hide resolved
beacon_chain/networking/network_metadata.nim
@@ -271,6 +273,8 @@ when not defined(gnosisChainBinary):
praterMetadata
of "ropsten":
ropstenMetadata
of "sepolia":
sepoliaMetadata
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

configDefaults seems to already have an entry for sepolia. I assume that one is still correct

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you clarify what you mean? Do you refer to the shouldSupportLightClient value?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep.

          let data = (genesisData[0 ..< 40].toHex())
          data in [
            # Kiln
            "0C572B620000000099B09FCD43E5905236C370F184056BEC6E6638CFC31A323B304FC4AA789CB4AD",
            # Ropsten
            "F0DB94620000000044F1E56283CA88B35C789F7F449E52339BC1FEFE3A45913A43A6D16EDCD33CF1",
            # Prater
            "60F4596000000000043DB0D9A83813551EE2F33450D23797757D430911A9320530AD8A0EABC43EFB",
            # Sepolia
            "607DB06200000000D8EA171F3C94AEA21EBC42A1ED61052ACF3F9209C00E4EFBAADDAC09ED9B8078",
          ]

Wondering if the Sepolia value here is still accurate.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct

@zah zah merged commit e8efc0f into unstable Jun 16, 2022
@zah zah deleted the sepolia-support branch June 16, 2022 14:11
@zah
Copy link
Contributor Author

zah commented Jun 16, 2022

Oops, I meant to enable auto-merge, but I merged the branch instead.

@zah zah mentioned this pull request Jun 16, 2022
Closed
@jakubgs jakubgs mentioned this pull request Jun 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etan-status etan-status etan-status approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zah @etan-status