rename light client config parameters #3740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For consistency with other options, use a common prefix for light client data configuration options. * `--serve-light-client-data` --> `--light-client-data-serve` * `--import-light-client-data` --> `--light-client-data-import-mode` No deprecation of the old identifiers as they were only sparingly used and all usage can be easily updated without interferance.
|
Can be merged once status-im/infra-nimbus#107 is accepted |
etan-status
added a commit
that referenced
this pull request
Jun 14, 2022
…/dag-statevars * commit '6bf7d6468036c3f010c6ce08727d63331ada5e0d': update CI timeouts (#3751) Fix /eth/v1/node/syncing (#3720) use block ID vs full block in LC data caching (#3741) cleanup LC data helpers (#3746) fix LC data import for Altair fork period (#3744) fix CI archive step (#3752) Support displaying the version number in the status bar; Implements #2959 (#3747) ci: install cmake on windows in daily job don't use slow-to-compress bzip2 with larger Jenkins artifacts rename light client config parameters (#3740) error handling for local testnet REST query (#3739) keep fcU consistent with actual DAG (#3748) remove unused `getExistingForkedBlock` overload (#3742) Version 22.5.2 change proposer boost to 40% bump merge-testnets to get new ropsten TTD (#3668)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For consistency with other options, use a common prefix for light client
data configuration options.
--serve-light-client-data-->--light-client-data-serve--import-light-client-data-->--light-client-data-import-modeNo deprecation of the old identifiers as they were only sparingly used
and all usage can be easily updated without interferance.