Fix the Keymanager API's delete URLs #3727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnetheduck
approved these changes
Jun 15, 2022
Other changes: * Make it easier to run the REST tests locally through a Makefile target
zah
force-pushed
the
fix-keymanager-delete-urls
branch
from
8b1f958
to
94c64b8
Compare
etan-status
reviewed
Jun 19, 2022
| restapi-test: | ||
| ./tests/simulation/restapi.sh \ | ||
| --data-dir resttest0_data \ | ||
| --base-port $$(( 9100 + EXECUTOR_NUMBER * 100 )) \ |
There was a problem hiding this comment.
does EXECUTOR_NUMBER make sense in the context of Makefile?
There was a problem hiding this comment.
It has a default value, but if you supply it in a ENV variable, it will have an effect. Since the Makefile target is used in the Jenkins CI, the variable is automatically specified by Jenkins there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.