Fixes for backfill syncing. #3304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cheatfate
commented
Jan 20, 2022
cheatfate
commented
- Fix backfill syncing never finishes in status message.
- Fix current slot number of both forward and backward syncing.
etan-status
added a commit
to etan-status/nimbus-eth2
that referenced
this pull request
Feb 13, 2022
status-im#3304 introduced a regression to the sync status string displayed in the status bar; during the main forward sync, the current slot is no longer reported and always displays as `0`. This patch corrects the computation to accurately report the current slot once more.
arnetheduck
pushed a commit
that referenced
this pull request
Feb 14, 2022
#3304 introduced a regression to the sync status string displayed in the status bar; during the main forward sync, the current slot is no longer reported and always displays as `0`. This patch corrects the computation to accurately report the current slot once more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.