Adds default impl for GatewayListener methods.

st2ne · Sep 7, 2018 · 3779ce0 · 3779ce0
1 parent c4df040
commit 3779ce0
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 49 deletions.
diff --git a/src/main/java/org/jitsi/jigasi/GatewayListener.java b/src/main/java/org/jitsi/jigasi/GatewayListener.java
@@ -29,22 +29,26 @@ public interface GatewayListener
      * Called when new session is added to the list of active sessions.
      * @param session the session that was added.
      */
-    void onSessionAdded(AbstractGatewaySession session);
+    default void onSessionAdded(AbstractGatewaySession session)
+    {}
 
     /**
      * Called when a session is removed from the list of active sessions.
      * @param session the session that was removed.
      */
-    void onSessionRemoved(AbstractGatewaySession session);
+    default void onSessionRemoved(AbstractGatewaySession session)
+    {}
 
     /**
      * Called when a session failed to establish.
      * @param session the session that failed.
      */
-    void onSessionFailed(AbstractGatewaySession session);
+    default void onSessionFailed(AbstractGatewaySession session)
+    {}
 
     /**
      * Called when the gateway is ready to create new sessions.
      */
-    void onReady();
+    default void onReady()
+    {}
 }
diff --git a/src/main/java/org/jitsi/jigasi/health/Health.java b/src/main/java/org/jitsi/jigasi/health/Health.java
@@ -68,18 +68,6 @@ public static void start()
                 final SipGateway finalSipGw = sipGateway;
                 sipGateway.addGatewayListener(new GatewayListener()
                 {
-                    @Override
-                    public void onSessionAdded(AbstractGatewaySession session)
-                    {}
-
-                    @Override
-                    public void onSessionRemoved(AbstractGatewaySession session)
-                    {}
-
-                    @Override
-                    public void onSessionFailed(AbstractGatewaySession session)
-                    {}
-
                     @Override
                     public void onReady()
                     {

diff --git a/src/main/java/org/jitsi/jigasi/rest/HandlerImpl.java b/src/main/java/org/jitsi/jigasi/rest/HandlerImpl.java
@@ -272,10 +272,6 @@ private void doGetStatisticsJSON(
         }
     }
 
-    @Override
-    public void onSessionAdded(AbstractGatewaySession session)
-    {}
-
     /**
      * When a session ends we add all the cumulative statistics.
      *
@@ -293,14 +289,6 @@ public void onSessionRemoved(AbstractGatewaySession session)
                     - session.getCallContext().getTimestamp()));
     }
 
-    @Override
-    public void onSessionFailed(AbstractGatewaySession session)
-    {}
-
-    @Override
-    public void onReady()
-    {}
-
     /**
      * Gets a JSON representation of the health (status) of a specific
      * {@link SipGateway}. The method is synchronized so anything other than

diff --git a/src/main/java/org/jitsi/jigasi/xmpp/CallControlMucActivator.java b/src/main/java/org/jitsi/jigasi/xmpp/CallControlMucActivator.java
@@ -340,14 +340,6 @@ public void onSessionRemoved(AbstractGatewaySession session)
         session.removeListener(this);
     }
 
-    @Override
-    public void onSessionFailed(AbstractGatewaySession session)
-    {}
-
-    @Override
-    public void onReady()
-    {}
-
     /**
      * Updates the presence in each {@link ProtocolProviderService} registered
      * with OSGi with the current number of conferences and participants.

diff --git a/src/test/java/org/jitsi/jigasi/GatewaySessions.java b/src/test/java/org/jitsi/jigasi/GatewaySessions.java
@@ -46,19 +46,6 @@ public void onSessionAdded(AbstractGatewaySession session)
         }
     }
 
-    @Override
-    public void onSessionRemoved(AbstractGatewaySession session)
-    {}
-
-    @Override
-    public void onSessionFailed(
-        AbstractGatewaySession session)
-    {}
-
-    @Override
-    public void onReady()
-    {}
-
     /**
      * Obtain sessions
      * @param timeout the time to wait to receive the sessions