This repository has been archived by the owner on Sep 11, 2020. It is now read-only.
plumbing: ssh, return error when creating public keys from invalid PEM #759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please, can you Signed-off your commit? @mdelillo |
* pem.Decode will return nil in this case, and passing that to x509.IsEncryptedBlock will cause it to panic Signed-off-by: Mark DeLillo <[email protected]>
mdelillo
force-pushed
the
invalid-ssh-key
branch
from
08dda15
to
779c88d
Compare
|
Sure thing |
mcuadros
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the
pemBytespassed in is not valid,pem.Decodewill return nil. Passing that tox509.IsEncryptedPEMBlockwill panic when it tries to readHeaders. This fix returns an error early rather than panicking.