Skip to content
This repository has been archived by the owner on Sep 11, 2020. It is now read-only.

remote: fetch, correct behavior on tags #485

Merged
merged 1 commit into from
Jul 17, 2017
Merged

remote: fetch, correct behavior on tags #485

merged 1 commit into from
Jul 17, 2017

Conversation

mcuadros
Copy link
Contributor

This fix #371 and #407

This PR remove the all behavior or fetching all the tags from a remote when a wildcard is being use, to the correct one.

It implements two different options TagFollowing, this means that fetch the tags from objects being fetch (or fetched) making usage of the include-tag capability, or the option AllTags downloading all the available tags.

@mcuadros mcuadros requested review from ajnavarro and smola July 17, 2017 07:02
@mcuadros mcuadros mentioned this pull request Jul 17, 2017
Copy link
Collaborator

@smola smola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to exclude include-tag capability when the AllTags options is used? Although it seems that git unconditionally enables it whenever it's supported.

@mcuadros
Copy link
Contributor Author

Yep, is kind of useless, and git is not using it when --tags is used.

@codecov
Copy link

codecov bot commented Jul 17, 2017

Codecov Report

Merging #485 into master will decrease coverage by 0.66%.
The diff coverage is 58.69%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #485      +/-   ##
=========================================
- Coverage   78.17%   77.5%   -0.67%     
=========================================
  Files         127     127              
  Lines        9304    9313       +9     
=========================================
- Hits         7273    7218      -55     
- Misses       1238    1314      +76     
+ Partials      793     781      -12
Impacted Files Coverage Δ
options.go 79.62% <ø> (ø) ⬆️
remote.go 71.54% <58.69%> (-0.98%) ⬇️
plumbing/transport/ssh/common.go 2.81% <0%> (-45.08%) ⬇️
plumbing/transport/ssh/auth_method.go 33.33% <0%> (-24.77%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 046b15e...cbdb258. Read the comment docs.

@mcuadros mcuadros merged commit d3c7400 into src-d:master Jul 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fetch remote tags to local
2 participants