This repository has been archived by the owner on Sep 11, 2020. It is now read-only.
capabilities: full integration #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 76.15% (diff: 86.25%)@@ master #151 diff @@
==========================================
Files 77 80 +3
Lines 5004 5150 +146
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 3797 3922 +125
- Misses 772 793 +21
Partials 435 435
|
smola
suggested changes
Nov 30, 2016
| @@ -3,10 +3,14 @@ package packp | |||
| import ( | |||
| "time" | |||
|
|
|||
| } | ||
|
|
||
| func (r *UploadRequest) validateConflictCapabilities() error { | ||
| msg := "capabilities %s and %s mutually exclusive" |
There was a problem hiding this comment.
"capabilities %s and %s mutually exclusive" -> "capabilities %s and %s are mutually exclusive"
| @@ -4,6 +4,7 @@ import ( | |||
| "testing" | |||
|
|
|||
| . "gopkg.in/check.v1" | |||
| "gopkg.in/src-d/go-git.v4/plumbing/protocol/packp/capability" | |||
alcortesm
approved these changes
Dec 1, 2016
mcuadros
added a commit
that referenced
this pull request
Jan 31, 2017
* format/pktline: fix readPayloadLen err handling * protocol/pakp: UploadReq validation and creation of capabilities * protocol/pakp: AdvRef tests * protocol/pakp: capability.List.Delete * protocol: filter unsupported capabilities * remote capability negociation * transport: UploadRequest validation * requested changes
gsalingu-ovhus
pushed a commit
to gsalingu-ovhus/go-git
that referenced
this pull request
Mar 28, 2019
rebase 1.2 rc1 on 1.1.1
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally the capabilities are being negotiated in the fetch request.
Each commit is meaningful is suggest go through the commits to understand the modifications: