This repository has been archived by the owner on Sep 11, 2020. It is now read-only.
Add configurable http client factory (fixes #120) #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ferhatelmas
commented
Nov 11, 2016
•
ferhatelmas
commented
- new http client factory ready to install/override default http(s)
- mv GitUploadPackServiceFactory to clients.common pkg
- rename http.HTTPError to http.Err
- rename http.HTTPAuthMethod to http.AuthMethod
- add doc and examples/ usage
- general improvements:
- update install link in readme to v4 (example are already pointing v4)
- fix indentation in package doc (styling for godoc.org)
- use http.Status constants instead of integers
- close leaked response body
- rm named returns which stutter in doc
- fix one format string
- rm unnecessary if checks
- documentation fixes
ferhatelmas
force-pushed
the
configurable-http-client
branch
from
9750213
to
e75f179
Compare
ferhatelmas
changed the title
ferhatelmas
force-pushed
the
configurable-http-client
branch
from
e75f179
to
9a4e2cf
Compare
|
Can you provide an example in examples folder or maybe at package level? or even better both? |
* new http client factory ready to install/override default http(s) * mv GitUploadPackServiceFactory to clients.common pkg * rename http.HTTPError to http.Err * rename http.HTTPAuthMethod to http.AuthMethod * add doc and examples/ usage * general improvements: - update install link in readme to v4 (example are already pointing v4) - fix indentation in package doc (styling for godoc.org) - use http.Status constants instead of integers - close leaked response body - rm named returns which stutter in doc - fix one format string - rm unnecessary if checks - documentation fixes
ferhatelmas
force-pushed
the
configurable-http-client
branch
from
9a4e2cf
to
eafea42
Compare
|
@mcuadros rebased and added examples (they don't do anything fancy but shows how client is customizable). |
mcuadros
pushed a commit
that referenced
this pull request
Jan 31, 2017
* new http client factory ready to install/override default http(s) * mv GitUploadPackServiceFactory to clients.common pkg * rename http.HTTPError to http.Err * rename http.HTTPAuthMethod to http.AuthMethod * add doc and examples/ usage * general improvements: - update install link in readme to v4 (example are already pointing v4) - fix indentation in package doc (styling for godoc.org) - use http.Status constants instead of integers - close leaked response body - rm named returns which stutter in doc - fix one format string - rm unnecessary if checks - documentation fixes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.