Skip to content
This repository has been archived by the owner on Sep 11, 2020. It is now read-only.

CloneOptions should reuse Auth method when recursing submodules #521

Closed
devonbarrett opened this issue Jul 29, 2017 · 1 comment
Closed

Comments

@devonbarrett
Copy link
Contributor

_, err := git.PlainClone(pathToService, false, &git.CloneOptions{
	URL:               "ssh://git@host:repo.git",
	Auth:              sshAuth,
	RecurseSubmodules: 10,
})
// err = error creating SSH agent: "SSH agent requested but SSH_AUTH_SOCK not-specified"

Observed

The PlainClone of the initial repository succeeds, however recursing submodules fail as they require use of the same transport.AuthMethod

Expected

The Auth method set in the CloneOptions is also used as a part of the SubmoduleUpdateOptions.Auth

Happy to make a PR if that is desirable?

@mcuadros
Copy link
Contributor

sure

mcuadros added a commit that referenced this issue Jul 29, 2017
reuse Auth method when recursing submodules, fixes #521
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants