Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal for a README #1

Merged
merged 8 commits into from
Aug 21, 2018
Merged

Proposal for a README #1

merged 8 commits into from
Aug 21, 2018

Conversation

eiso
Copy link
Member

@eiso eiso commented Aug 18, 2018

Since the engine-cli will be the entry point for many users, I was thinking, so should be the repository, Therefore I've written a README based upon the excellent structure of prisma. Some of the content is still placeholder and will need to be filled out further.

@eiso eiso requested a review from campoy August 18, 2018 21:28
Copy link
Contributor

@campoy campoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, just a couple of changes.

README.md Outdated

```
# Without a path it operates on the local folder,
# it works with nested folder.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/folder/folders/

srcd sql
```

This will open a SQL client that allows you to execute queries against your repositories.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd mention that you can also run the requests directly from the command line: srcd sql "show tables;"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

## Contributing

Contributions are **welcome and very much appreciated** 🙌
Please refer [to our contribution guide](CONTRIBUTING.md) for more details.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Links to nowhere

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By design, there are placeholders here, for you to add. I felt you should be writing the contributing guide (editing/adding to our template that can be found in the guide).

@eiso
Copy link
Member Author

eiso commented Aug 21, 2018

Note for maintainer:

  • Services behind the badges need to be activated
  • Windows instructions need to be added
  • A decision on if this cli is added to any package managers like npm on apt-get
  • Next steps is complete placeholder right now, would like some input here
  • Guides & Examples is incomplete
  • See if there are any other projects you want to mention in the credits section, maybe Docker one?
  • We should add more queries

@eiso
Copy link
Member Author

eiso commented Aug 21, 2018

@campoy if you like the idea as well, I added a badge to link to our design document. I suggest we do this on all of our projects that have a design doc.

@campoy campoy merged commit e39a1b2 into master Aug 21, 2018
@eiso eiso deleted the readme branch August 28, 2018 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants