Update to new Gradle dependency configurations

[ShaishavGandhi]

Signed-off-by: shaishavgandhi05 [email protected]

[JakeWharton]

The use of implementation for OkHttp might not be accurate. For example, if we were to use this from Retrofit it would be incorrect as OkHttp types are exposed in Retrofit's API.

[ShaishavGandhi]

True. Using implementation or api depends on the use case. I would be open to adding both
implementation 'com.squareup.okhttp3:okhttp:3.9.1' and api 'com.squareup.okhttp3:okhttp:3.9.1' both and adding a line explaining if you want okhttp types to be exposed beyond your module, you should use api.

[JakeWharton]

Yeah it's an unfortunate side-effect of this new system. I'm not really sure what's best to do. Another potential approach is to only list the coordinates like

com.squareup.okhttp3:okhttp:3.9.0

and let people figure out how to apply that to Gradle, Maven, or whatever.

Anyone else have an opinion here? The problem is we have about 30 projects which have very similar READMEs so whatever we do it'd be nice to unify them in the new style.

[yschimke]

I think @shaishavgandhi05 suggestion is the best one, use implementation as the only example, as most end users will use that. Then a one line note referencing "api" for library maintainers to use is types are part of public API.

[ShaishavGandhi]

I've kept implementation as it is and added a note about using OkHttp in a library and exposing its types in the public API.

[NightlyNexus]

I'd like to eliminate the noisy boilerplate of READMEs that shows lines for build systems.
Having only the coordinates would be nice.

Unfortunately, I'm imagining hundreds of issues filed asking how to set every library up with Gradle and Maven.

Seems like implementation is good enough to be the copypasta.

[swankjesse]

I removed the note about api vs. implementation, which seemed off-topic for OkHttp. Lets do the same for all of our READMEs. Yay!