Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement metadata tags for social media previews, add OS version to macOS, and replace OS images with new ones #7

Merged
merged 10 commits into from
Sep 13, 2024

Conversation

conradolandia
Copy link
Collaborator

@conradolandia conradolandia commented Sep 4, 2024

This PR implements OG metadata for social media sharing.

Fixes #11

Copy link

netlify bot commented Sep 4, 2024

Deploy Preview for spyder-svelte-website-preview ready!

Name Link
🔨 Latest commit c53e3da
🔍 Latest deploy log https://app.netlify.com/sites/spyder-svelte-website-preview/deploys/66e2289e56d0a1000863fb8c
😎 Deploy Preview https://deploy-preview-7--spyder-svelte-website-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@CAM-Gerlach
Copy link
Member

Hmm, is there something I'm missing here about how the opengraph tags and the download links/images are related or depend upon one another?

@conradolandia
Copy link
Collaborator Author

I'm not sure what you mean?

@ccordoba12
Copy link
Member

@CAM-Gerlach, I think this is ready so could you clarify what you meant before?

Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content LGTM now with the new images (aside from the unrelated changes conflated into one PR), thanks @conradolandia

@CAM-Gerlach CAM-Gerlach merged commit e3c2db0 into spyder-ide:main Sep 13, 2024
2 checks passed
@conradolandia conradolandia deleted the metadata-preview branch September 17, 2024 03:37
@CAM-Gerlach CAM-Gerlach linked an issue Sep 19, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add OpenGraph metadata for improved preview when sharing website
3 participants