Skip to content

Commit

Permalink
dashboard/app: add review subrepo, link changes correctly
Browse files Browse the repository at this point in the history
Change-Id: I1eeea2beb4ffab690b2bb005c08a08d7e41c1fc3
Reviewed-on: https://go-review.googlesource.com/1503
Reviewed-by: Minux Ma <[email protected]>
Reviewed-by: Andrew Gerrand <[email protected]>
  • Loading branch information
adg committed Dec 13, 2014
1 parent 551edbf commit 05fa16d
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 1 deletion.
5 changes: 5 additions & 0 deletions dashboard/app/build/dash.go
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,11 @@ var goPackages = []*Package{
Name: "net",
Path: "golang.org/x/net",
},
{
Kind: "subrepo",
Name: "review",
Path: "golang.org/x/review",
},
{
Kind: "subrepo",
Name: "sys",
Expand Down
6 changes: 5 additions & 1 deletion dashboard/app/build/ui.go
Original file line number Diff line number Diff line change
Expand Up @@ -435,7 +435,11 @@ func repoURL(dashboard, hash, packagePath string) (string, error) {
if dashboard == "Gccgo" {
return "https://code.google.com/p/gofrontend/source/detail?r=" + hash, nil
}
return "https://golang.org/change/" + hash, nil
if dashboard == "Mercurial" {
return "https://golang.org/change/" + hash, nil
}
// TODO(adg): use the above once /change/ points to git hashes
return "https://go.googlesource.com/go/+/" + hash, nil
}

// TODO(adg): remove this old hg stuff, one day.
Expand Down

0 comments on commit 05fa16d

Please sign in to comment.