-
Notifications
You must be signed in to change notification settings - Fork 40.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reinstate support for auto-configuring an embedded ActiveMQ broker #40029
Conversation
2fb6829
to
31eb469
Compare
spring-boot-project/spring-boot-docs/src/docs/asciidoc/messaging/jms.adoc
Outdated
Show resolved
Hide resolved
02f7279
to
0024927
Compare
How's it going, @mattrpav? Do you still have plans to finish this off? |
@wilkinsona Thanks for the ping. Yes, I plan to get this wrapped up. What is the timeframe to make it in the next Spring Boot release? |
@mattrpav Since this would be considered a feature addition, we would only add it in a new minor release. The next scheduled minor release is 3.4 in November of this year. There will be several milestone releases and a release candidate leading up to the minor version release, which would give users a chance to try it out. |
@mattrpav I've looked at what you've done and there's the question of whether we want to reinstate the behavior as it was before. To figure that out, I am happy to look at the various options and polish your proposal. Are you ok with that? We'd like to make sure you haven't wasted time on this. |
@snicoll I have the WIP PR at about 80% and I'll have time to wrap this up soon. A couple ActiveMQ upstream releases are wrapping up, so I can turn my attention to finish this. Generally, it would seem that providing the like-for-like would ease transition for spring-jms users to make the javax.* to jakarta.* transition. At the same time, improvements always sound compelling, what did you have in mind? Can these be done side-by-side with the existing capabilities and property flags? I'm hearing from a lot of users that are waiting for this to make the transition to Jakarta-based Spring. A lot of folks have long time investments in ActiveMQ and the other alternatives do not suit their needs. |
Can you push the code then?
I didn't mention improvements. It's figuring out how we get from what we have to this. Right now, Spring Boot 3.x users of ActiveMQ with no configuration would get an infrastructure that connects to an existing broker on localhost using tcp. After this change, it would use an embedded broker in memory. This can be very surprising and we're wondering if that's what we should be doing. |
@mattrpav is this PR ready for review now? |
@mattrpav thanks for the proposal but it's incomplete and the build is failing. Also, we can't just add the broker in the starter as you suggest as it would be a breaking change. I am taking over. |
#38404