Add type safe getters to execution context #718
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves BATCH-2779
Resolves BATCH-2768 (cherry picked from commit e707a57)
The command `ping 1.1.1.1 -n 1 -w 5000` sends only one packet to the remote address and might finish before the configured timeout of 10ms which makes some tests to fail. Moreover, pinging 1.1.1.1 requires the host (which can be the CI build server) to have internet connection. This command can also fail if there is no internet connection which makes some tests (expecting the command to succeed) to fail too. This commit uses the command `ping 127.0.0.1` which does not require an internet connection and which will, by default [1], send 4 packets and wait for a timeout of 4 seconds for each request. This should take more time than the configured timeout of 10ms. Resolves BATCH-2722 [1]: https://docs.microsoft.com/en-us/windows-server/administration/windows-commands/ping (cherry picked from commit 1bfabeb)
(cherry picked from commit c9f72cd)
The `testMultipleSimultaneousInstances` test uses a SimpleAsyncTaskExecutor. This means when a job is submitted, a new thread will be created to run the job. However, there could be a small time interval between JobOperator.startNextInstance(job) and JobOperator.findRunningExecutions(job) where the job execution is created but not started yet. When this happens, the test fails as `findRunningExecutions` does not return the just created (but not started yet) execution. This commit adds a `Thread.sleep` between these two invocations in order to give a chance to the background thread (to be created and) to execute the job. (cherry picked from commit 90a89c1)
Tests modified in this change set fail randomly due to shared mutable state between multiple threads. This commit ensures that the shared state is correctly synchronised between threads or re-initialized before each test run. (cherry picked from commit eba7265)
(cherry picked from commit 422c233)
(cherry picked from commit 797fe1b)
(cherry picked from commit ffe158c)
MariaDB is a fork of MySQL
This commit updates URLs to prefer the https protocol. Redirects are not followed to avoid accidentally expanding intentionally shortened URLs (i.e. if using a URL shortener). # Fixed URLs ## Fixed Success These URLs were switched to an https URL with a 2xx status. While the status was successful, your review is still recommended. * http://projects.spring.io/spring-batch/ with 1 occurrences migrated to: https://projects.spring.io/spring-batch/ ([https](https://projects.spring.io/spring-batch/) result 200). * http://spring.io with 1 occurrences migrated to: https://spring.io ([https](https://spring.io) result 200). * http://www.apache.org/licenses/LICENSE-2.0.txt with 1 occurrences migrated to: https://www.apache.org/licenses/LICENSE-2.0.txt ([https](https://www.apache.org/licenses/LICENSE-2.0.txt) result 200).
This commit updates URLs to prefer the https protocol. Redirects are not followed to avoid accidentally expanding intentionally shortened URLs (i.e. if using a URL shortener). # Fixed URLs ## Fixed Success These URLs were switched to an https URL with a 2xx status. While the status was successful, your review is still recommended. * [ ] http://www.apache.org/licenses/ with 2 occurrences migrated to: https://www.apache.org/licenses/ ([https](https://www.apache.org/licenses/) result 200). * [ ] http://www.apache.org/licenses/LICENSE-2.0 with 1798 occurrences migrated to: https://www.apache.org/licenses/LICENSE-2.0 ([https](https://www.apache.org/licenses/LICENSE-2.0) result 200).
This commit updates URLs to prefer the https protocol. Redirects are not followed to avoid accidentally expanding intentionally shortened URLs (i.e. if using a URL shortener). # Fixed URLs ## Fixed Success These URLs were switched to an https URL with a 2xx status. While the status was successful, your review is still recommended. * [ ] http://www.hibernate.org/dtd/hibernate-mapping-3.0.dtd (301) with 1 occurrences migrated to: https://hibernate.org/dtd/hibernate-mapping-3.0.dtd ([https](https://www.hibernate.org/dtd/hibernate-mapping-3.0.dtd) result 200). * [ ] http://hibernate.sourceforge.net/hibernate-mapping-3.0.dtd (301) with 2 occurrences migrated to: https://hibernate.org/dtd/hibernate-mapping-3.0.dtd ([https](https://hibernate.sourceforge.net/hibernate-mapping-3.0.dtd) result 200). * [ ] http://xmlns.jcp.org/xml/ns/javaee/jobXML_1_0.xsd (301) with 29 occurrences migrated to: https://www.oracle.com/webfolder/technetwork/jsc/xml/ns/javaee/jobXML_1_0.xsd ([https](https://xmlns.jcp.org/xml/ns/javaee/jobXML_1_0.xsd) result 200). * [ ] http://www.springframework.org/schema/aop/spring-aop-2.5.xsd with 5 occurrences migrated to: https://www.springframework.org/schema/aop/spring-aop-2.5.xsd ([https](https://www.springframework.org/schema/aop/spring-aop-2.5.xsd) result 200). * [ ] http://www.springframework.org/schema/aop/spring-aop-3.1.xsd with 21 occurrences migrated to: https://www.springframework.org/schema/aop/spring-aop-3.1.xsd ([https](https://www.springframework.org/schema/aop/spring-aop-3.1.xsd) result 200). * [ ] http://www.springframework.org/schema/aop/spring-aop.xsd with 27 occurrences migrated to: https://www.springframework.org/schema/aop/spring-aop.xsd ([https](https://www.springframework.org/schema/aop/spring-aop.xsd) result 200). * [ ] http://www.springframework.org/schema/batch-integration/spring-batch-integration.xsd with 16 occurrences migrated to: https://www.springframework.org/schema/batch-integration/spring-batch-integration.xsd ([https](https://www.springframework.org/schema/batch-integration/spring-batch-integration.xsd) result 200). * [ ] http://www.springframework.org/schema/batch/spring-batch-2.0.xsd with 1 occurrences migrated to: https://www.springframework.org/schema/batch/spring-batch-2.0.xsd ([https](https://www.springframework.org/schema/batch/spring-batch-2.0.xsd) result 200). * [ ] http://www.springframework.org/schema/batch/spring-batch-2.1.xsd with 1 occurrences migrated to: https://www.springframework.org/schema/batch/spring-batch-2.1.xsd ([https](https://www.springframework.org/schema/batch/spring-batch-2.1.xsd) result 200). * [ ] http://www.springframework.org/schema/batch/spring-batch-2.2.xsd with 99 occurrences migrated to: https://www.springframework.org/schema/batch/spring-batch-2.2.xsd ([https](https://www.springframework.org/schema/batch/spring-batch-2.2.xsd) result 200). * [ ] http://www.springframework.org/schema/batch/spring-batch-3.0.xsd with 1 occurrences migrated to: https://www.springframework.org/schema/batch/spring-batch-3.0.xsd ([https](https://www.springframework.org/schema/batch/spring-batch-3.0.xsd) result 200). * [ ] http://www.springframework.org/schema/batch/spring-batch.xsd with 51 occurrences migrated to: https://www.springframework.org/schema/batch/spring-batch.xsd ([https](https://www.springframework.org/schema/batch/spring-batch.xsd) result 200). * [ ] http://www.springframework.org/schema/beans/spring-beans-2.0.xsd with 1 occurrences migrated to: https://www.springframework.org/schema/beans/spring-beans-2.0.xsd ([https](https://www.springframework.org/schema/beans/spring-beans-2.0.xsd) result 200). * [ ] http://www.springframework.org/schema/beans/spring-beans-2.5.xsd with 14 occurrences migrated to: https://www.springframework.org/schema/beans/spring-beans-2.5.xsd ([https](https://www.springframework.org/schema/beans/spring-beans-2.5.xsd) result 200). * [ ] http://www.springframework.org/schema/beans/spring-beans-3.1.xsd with 145 occurrences migrated to: https://www.springframework.org/schema/beans/spring-beans-3.1.xsd ([https](https://www.springframework.org/schema/beans/spring-beans-3.1.xsd) result 200). * [ ] http://www.springframework.org/schema/beans/spring-beans.xsd with 166 occurrences migrated to: https://www.springframework.org/schema/beans/spring-beans.xsd ([https](https://www.springframework.org/schema/beans/spring-beans.xsd) result 200). * [ ] http://www.springframework.org/schema/context/spring-context-2.5.xsd with 8 occurrences migrated to: https://www.springframework.org/schema/context/spring-context-2.5.xsd ([https](https://www.springframework.org/schema/context/spring-context-2.5.xsd) result 200). * [ ] http://www.springframework.org/schema/context/spring-context-3.1.xsd with 2 occurrences migrated to: https://www.springframework.org/schema/context/spring-context-3.1.xsd ([https](https://www.springframework.org/schema/context/spring-context-3.1.xsd) result 200). * [ ] http://www.springframework.org/schema/context/spring-context-3.2.xsd with 1 occurrences migrated to: https://www.springframework.org/schema/context/spring-context-3.2.xsd ([https](https://www.springframework.org/schema/context/spring-context-3.2.xsd) result 200). * [ ] http://www.springframework.org/schema/context/spring-context.xsd with 15 occurrences migrated to: https://www.springframework.org/schema/context/spring-context.xsd ([https](https://www.springframework.org/schema/context/spring-context.xsd) result 200). * [ ] http://www.springframework.org/schema/data/jpa/spring-jpa.xsd with 1 occurrences migrated to: https://www.springframework.org/schema/data/jpa/spring-jpa.xsd ([https](https://www.springframework.org/schema/data/jpa/spring-jpa.xsd) result 200). * [ ] http://www.springframework.org/schema/integration/jdbc/spring-integration-jdbc.xsd with 1 occurrences migrated to: https://www.springframework.org/schema/integration/jdbc/spring-integration-jdbc.xsd ([https](https://www.springframework.org/schema/integration/jdbc/spring-integration-jdbc.xsd) result 200). * [ ] http://www.springframework.org/schema/integration/jms/spring-integration-jms-2.0.xsd with 1 occurrences migrated to: https://www.springframework.org/schema/integration/jms/spring-integration-jms-2.0.xsd ([https](https://www.springframework.org/schema/integration/jms/spring-integration-jms-2.0.xsd) result 200). * [ ] http://www.springframework.org/schema/integration/jms/spring-integration-jms.xsd with 3 occurrences migrated to: https://www.springframework.org/schema/integration/jms/spring-integration-jms.xsd ([https](https://www.springframework.org/schema/integration/jms/spring-integration-jms.xsd) result 200). * [ ] http://www.springframework.org/schema/integration/spring-integration.xsd with 27 occurrences migrated to: https://www.springframework.org/schema/integration/spring-integration.xsd ([https](https://www.springframework.org/schema/integration/spring-integration.xsd) result 200). * [ ] http://www.springframework.org/schema/jdbc/spring-jdbc-3.2.xsd with 1 occurrences migrated to: https://www.springframework.org/schema/jdbc/spring-jdbc-3.2.xsd ([https](https://www.springframework.org/schema/jdbc/spring-jdbc-3.2.xsd) result 200). * [ ] http://www.springframework.org/schema/jdbc/spring-jdbc.xsd with 3 occurrences migrated to: https://www.springframework.org/schema/jdbc/spring-jdbc.xsd ([https](https://www.springframework.org/schema/jdbc/spring-jdbc.xsd) result 200). * [ ] http://www.springframework.org/schema/jms/spring-jms.xsd with 2 occurrences migrated to: https://www.springframework.org/schema/jms/spring-jms.xsd ([https](https://www.springframework.org/schema/jms/spring-jms.xsd) result 200). * [ ] http://www.springframework.org/schema/lang/spring-lang.xsd with 1 occurrences migrated to: https://www.springframework.org/schema/lang/spring-lang.xsd ([https](https://www.springframework.org/schema/lang/spring-lang.xsd) result 200). * [ ] http://www.springframework.org/schema/rabbit/spring-rabbit.xsd with 1 occurrences migrated to: https://www.springframework.org/schema/rabbit/spring-rabbit.xsd ([https](https://www.springframework.org/schema/rabbit/spring-rabbit.xsd) result 200). * [ ] http://www.springframework.org/schema/task/spring-task-3.0.xsd with 1 occurrences migrated to: https://www.springframework.org/schema/task/spring-task-3.0.xsd ([https](https://www.springframework.org/schema/task/spring-task-3.0.xsd) result 200). * [ ] http://www.springframework.org/schema/task/spring-task.xsd with 2 occurrences migrated to: https://www.springframework.org/schema/task/spring-task.xsd ([https](https://www.springframework.org/schema/task/spring-task.xsd) result 200). * [ ] http://www.springframework.org/schema/tx/spring-tx-2.5.xsd with 8 occurrences migrated to: https://www.springframework.org/schema/tx/spring-tx-2.5.xsd ([https](https://www.springframework.org/schema/tx/spring-tx-2.5.xsd) result 200). * [ ] http://www.springframework.org/schema/tx/spring-tx-3.1.xsd with 16 occurrences migrated to: https://www.springframework.org/schema/tx/spring-tx-3.1.xsd ([https](https://www.springframework.org/schema/tx/spring-tx-3.1.xsd) result 200). * [ ] http://www.springframework.org/schema/tx/spring-tx.xsd with 21 occurrences migrated to: https://www.springframework.org/schema/tx/spring-tx.xsd ([https](https://www.springframework.org/schema/tx/spring-tx.xsd) result 200). * [ ] http://www.springframework.org/schema/util/spring-util-3.1.xsd with 9 occurrences migrated to: https://www.springframework.org/schema/util/spring-util-3.1.xsd ([https](https://www.springframework.org/schema/util/spring-util-3.1.xsd) result 200). * [ ] http://www.springframework.org/schema/util/spring-util.xsd with 15 occurrences migrated to: https://www.springframework.org/schema/util/spring-util.xsd ([https](https://www.springframework.org/schema/util/spring-util.xsd) result 200). * [ ] http://www.w3.org/Graphics/SVG/1.1/DTD/svg11.dtd with 1 occurrences migrated to: https://www.w3.org/Graphics/SVG/1.1/DTD/svg11.dtd ([https](https://www.w3.org/Graphics/SVG/1.1/DTD/svg11.dtd) result 200). * [ ] http://java.sun.com/xml/ns/persistence/persistence_1_0.xsd with 3 occurrences migrated to: https://java.sun.com/xml/ns/persistence/persistence_1_0.xsd ([https](https://java.sun.com/xml/ns/persistence/persistence_1_0.xsd) result 302). # Ignored These URLs were intentionally ignored. * http://java.sun.com/xml/ns/persistence with 6 occurrences * http://purl.org/dc/elements/1.1/ with 1 occurrences * http://www.springframework.org/schema/aop with 104 occurrences * http://www.springframework.org/schema/batch with 343 occurrences * http://www.springframework.org/schema/batch-integration with 32 occurrences * http://www.springframework.org/schema/batch/test with 1 occurrences * http://www.springframework.org/schema/beans with 673 occurrences * http://www.springframework.org/schema/context with 52 occurrences * http://www.springframework.org/schema/data/jpa with 2 occurrences * http://www.springframework.org/schema/integration with 65 occurrences * http://www.springframework.org/schema/integration/jdbc with 2 occurrences * http://www.springframework.org/schema/integration/jms with 6 occurrences * http://www.springframework.org/schema/jdbc with 8 occurrences * http://www.springframework.org/schema/jms with 3 occurrences * http://www.springframework.org/schema/lang with 2 occurrences * http://www.springframework.org/schema/p with 60 occurrences * http://www.springframework.org/schema/rabbit with 2 occurrences * http://www.springframework.org/schema/task with 6 occurrences * http://www.springframework.org/schema/tx with 89 occurrences * http://www.springframework.org/schema/util with 48 occurrences * http://www.w3.org/1999/xlink with 1 occurrences * http://www.w3.org/2000/svg with 1 occurrences * http://www.w3.org/2001/XMLSchema-instance with 330 occurrences * http://xmlns.jcp.org/xml/ns/javaee with 82 occurrences
This commit updates URLs to prefer the https protocol. Redirects are not followed to avoid accidentally expanding intentionally shortened URLs (i.e. if using a URL shortener). # HTTP URLs that Could Not Be Fixed These URLs were unable to be fixed. Please review them to see if they can be manually resolved. * [ ] http://erik.eae.net/archives/2007/07/27/18.54.15/ (200) with 1 occurrences could not be migrated: ([https](https://erik.eae.net/archives/2007/07/27/18.54.15/) result SSLHandshakeException). * [ ] http://gregfranko.com/jquery.tocify.js/ (200) with 1 occurrences could not be migrated: ([https](https://gregfranko.com/jquery.tocify.js/) result SSLHandshakeException). * [ ] http://javascript.nwbox.com/IEContentLoaded/ (200) with 1 occurrences could not be migrated: ([https](https://javascript.nwbox.com/IEContentLoaded/) result SSLHandshakeException). * [ ] http://jeremyworboys.com/writing/toggle-buttons-without-javascript (200) with 1 occurrences could not be migrated: ([https](https://jeremyworboys.com/writing/toggle-buttons-without-javascript) result SSLHandshakeException). * [ ] http://nicolasgallagher.com/micro-clearfix-hack/ (200) with 1 occurrences could not be migrated: ([https](https://nicolasgallagher.com/micro-clearfix-hack/) result SSLHandshakeException). * [ ] http://blindsignals.com/index.php/2009/07/jquery-delay/ (301) with 1 occurrences could not be migrated: ([https](https://blindsignals.com/index.php/2009/07/jquery-delay/) result SSLHandshakeException). # Fixed URLs ## Fixed But Review Recommended These URLs were fixed, but the https status was not OK. However, the https status was the same as the http request or http redirected to an https URL, so they were migrated. Your review is recommended. * [ ] http://jsperf.com/getall-vs-sizzle/2 (301) with 1 occurrences migrated to: https://jsperf.com/getall-vs-sizzle/2 ([https](https://jsperf.com/getall-vs-sizzle/2) result ReadTimeoutException). * [ ] http://wiki.ecmascript.org/doku.php?id=harmony:egal (ConnectTimeoutException) with 1 occurrences migrated to: https://wiki.ecmascript.org/doku.php?id=harmony:egal ([https](https://wiki.ecmascript.org/doku.php?id=harmony:egal) result ConnectTimeoutException). * [ ] http://api.example.com (UnknownHostException) with 1 occurrences migrated to: https://api.example.com ([https](https://api.example.com) result UnknownHostException). * [ ] http://jira.codehaus.org/browse/WSTX-165 (UnknownHostException) with 1 occurrences migrated to: https://jira.codehaus.org/browse/WSTX-165 ([https](https://jira.codehaus.org/browse/WSTX-165) result UnknownHostException). * [ ] http://fluidproject.org/blog/2008/01/09/getting-setting-and-removing-tabindex-values-with-javascript/ (301) with 1 occurrences migrated to: https://fluidproject.org/blog/2008/01/09/getting-setting-and-removing-tabindex-values-with-javascript/ ([https](https://fluidproject.org/blog/2008/01/09/getting-setting-and-removing-tabindex-values-with-javascript/) result 404). * [ ] http://help.github.com/send-pull-requests (404) with 1 occurrences migrated to: https://help.github.com/send-pull-requests ([https](https://help.github.com/send-pull-requests) result 404). * [ ] http://json.org/json2.js (404) with 1 occurrences migrated to: https://json.org/json2.js ([https](https://json.org/json2.js) result 404). * [ ] http://springframework.org/batch/sample/io/oxm/domain (404) with 3 occurrences migrated to: https://springframework.org/batch/sample/io/oxm/domain ([https](https://springframework.org/batch/sample/io/oxm/domain) result 404). * [ ] http://www.springframework.org/test (404) with 34 occurrences migrated to: https://www.springframework.org/test ([https](https://www.springframework.org/test) result 404). ## Fixed Success These URLs were switched to an https URL with a 2xx status. While the status was successful, your review is still recommended. * [ ] http://backbonejs.org with 1 occurrences migrated to: https://backbonejs.org ([https](https://backbonejs.org) result 200). * [ ] http://bugs.jquery.com/ticket/12282 with 1 occurrences migrated to: https://bugs.jquery.com/ticket/12282 ([https](https://bugs.jquery.com/ticket/12282) result 200). * [ ] http://bugs.jquery.com/ticket/12359 with 1 occurrences migrated to: https://bugs.jquery.com/ticket/12359 ([https](https://bugs.jquery.com/ticket/12359) result 200). * [ ] http://bugs.jquery.com/ticket/13378 with 1 occurrences migrated to: https://bugs.jquery.com/ticket/13378 ([https](https://bugs.jquery.com/ticket/13378) result 200). * [ ] http://db.apache.org/derby/papers/versionupgrade.html with 1 occurrences migrated to: https://db.apache.org/derby/papers/versionupgrade.html ([https](https://db.apache.org/derby/papers/versionupgrade.html) result 200). * [ ] http://diveintohtml5.info/history.html with 1 occurrences migrated to: https://diveintohtml5.info/history.html ([https](https://diveintohtml5.info/history.html) result 200). * [ ] http://docs.oracle.com/javase/tutorial/java/generics/capture.html with 2 occurrences migrated to: https://docs.oracle.com/javase/tutorial/java/generics/capture.html ([https](https://docs.oracle.com/javase/tutorial/java/generics/capture.html) result 200). * [ ] http://docs.spring.io/spring-batch/trunk/reference/ with 1 occurrences migrated to: https://docs.spring.io/spring-batch/trunk/reference/ ([https](https://docs.spring.io/spring-batch/trunk/reference/) result 200). * [ ] http://docs.spring.io/spring-batch/trunk/reference/html/index.html with 1 occurrences migrated to: https://docs.spring.io/spring-batch/trunk/reference/html/index.html ([https](https://docs.spring.io/spring-batch/trunk/reference/html/index.html) result 200). * [ ] http://docs.spring.io/spring/docs/current/javadoc-api/org/springframework/transaction/interceptor/TransactionAttributeEditor.html with 1 occurrences migrated to: https://docs.spring.io/spring/docs/current/javadoc-api/org/springframework/transaction/interceptor/TransactionAttributeEditor.html ([https](https://docs.spring.io/spring/docs/current/javadoc-api/org/springframework/transaction/interceptor/TransactionAttributeEditor.html) result 200). * [ ] http://github.com/spring-projects/spring-batch with 1 occurrences migrated to: https://github.com/spring-projects/spring-batch ([https](https://github.com/spring-projects/spring-batch) result 200). * [ ] http://jira.spring.io/browse/BATCH-1681 with 1 occurrences migrated to: https://jira.spring.io/browse/BATCH-1681 ([https](https://jira.spring.io/browse/BATCH-1681) result 200). * [ ] http://jira.spring.io/browse/BATCH-761 with 1 occurrences migrated to: https://jira.spring.io/browse/BATCH-761 ([https](https://jira.spring.io/browse/BATCH-761) result 200). * [ ] http://jquery.com/ with 1 occurrences migrated to: https://jquery.com/ ([https](https://jquery.com/) result 200). * [ ] http://projects.spring.io/spring-batch/ with 2 occurrences migrated to: https://projects.spring.io/spring-batch/ ([https](https://projects.spring.io/spring-batch/) result 200). * [ ] http://projects.spring.io/spring-batch/faq.html with 1 occurrences migrated to: https://projects.spring.io/spring-batch/faq.html ([https](https://projects.spring.io/spring-batch/faq.html) result 200). * [ ] http://projects.spring.io/spring-integration/ with 1 occurrences migrated to: https://projects.spring.io/spring-integration/ ([https](https://projects.spring.io/spring-integration/) result 200). * [ ] http://sizzlejs.com/ with 2 occurrences migrated to: https://sizzlejs.com/ ([https](https://sizzlejs.com/) result 200). * [ ] http://spring.io/guides/gs/batch-processing/ with 1 occurrences migrated to: https://spring.io/guides/gs/batch-processing/ ([https](https://spring.io/guides/gs/batch-processing/) result 200). * [ ] http://spring.io/projects with 1 occurrences migrated to: https://spring.io/projects ([https](https://spring.io/projects) result 200). * [ ] http://spring.io/tools with 1 occurrences migrated to: https://spring.io/tools ([https](https://spring.io/tools) result 200). * [ ] http://stackoverflow.com/questions/134882/undoing-a-git-rebase with 1 occurrences migrated to: https://stackoverflow.com/questions/134882/undoing-a-git-rebase ([https](https://stackoverflow.com/questions/134882/undoing-a-git-rebase) result 200). * [ ] http://underscorejs.org with 1 occurrences migrated to: https://underscorejs.org ([https](https://underscorejs.org) result 200). * [ ] http://unlicense.org with 1 occurrences migrated to: https://unlicense.org ([https](https://unlicense.org) result 200). * [ ] http://www.apache.org with 1 occurrences migrated to: https://www.apache.org ([https](https://www.apache.org) result 200). * [ ] http://xmlns.jcp.org/xml/ns/javaee/jobXML_1_0.xsd (301) with 1 occurrences migrated to: https://www.oracle.com/webfolder/technetwork/jsc/xml/ns/javaee/jobXML_1_0.xsd ([https](https://xmlns.jcp.org/xml/ns/javaee/jobXML_1_0.xsd) result 200). * [ ] http://www.ow2.org/ with 1 occurrences migrated to: https://www.ow2.org/ ([https](https://www.ow2.org/) result 200). * [ ] http://www.springframework.org/schema/batch-integration/spring-batch-integration.xsd with 2 occurrences migrated to: https://www.springframework.org/schema/batch-integration/spring-batch-integration.xsd ([https](https://www.springframework.org/schema/batch-integration/spring-batch-integration.xsd) result 200). * [ ] http://www.springframework.org/schema/batch/spring-batch.xsd with 2 occurrences migrated to: https://www.springframework.org/schema/batch/spring-batch.xsd ([https](https://www.springframework.org/schema/batch/spring-batch.xsd) result 200). * [ ] http://www.springframework.org/schema/beans/spring-beans-2.5.xsd with 3 occurrences migrated to: https://www.springframework.org/schema/beans/spring-beans-2.5.xsd ([https](https://www.springframework.org/schema/beans/spring-beans-2.5.xsd) result 200). * [ ] http://www.springframework.org/schema/beans/spring-beans-3.1.xsd with 1 occurrences migrated to: https://www.springframework.org/schema/beans/spring-beans-3.1.xsd ([https](https://www.springframework.org/schema/beans/spring-beans-3.1.xsd) result 200). * [ ] http://www.springframework.org/schema/beans/spring-beans-3.2.xsd with 1 occurrences migrated to: https://www.springframework.org/schema/beans/spring-beans-3.2.xsd ([https](https://www.springframework.org/schema/beans/spring-beans-3.2.xsd) result 200). * [ ] http://www.springframework.org/schema/beans/spring-beans.xsd with 3 occurrences migrated to: https://www.springframework.org/schema/beans/spring-beans.xsd ([https](https://www.springframework.org/schema/beans/spring-beans.xsd) result 200). * [ ] http://www.springframework.org/schema/integration/spring-integration.xsd with 3 occurrences migrated to: https://www.springframework.org/schema/integration/spring-integration.xsd ([https](https://www.springframework.org/schema/integration/spring-integration.xsd) result 200). * [ ] http://www.springframework.org/schema/tool/spring-tool-2.5.xsd with 1 occurrences migrated to: https://www.springframework.org/schema/tool/spring-tool-2.5.xsd ([https](https://www.springframework.org/schema/tool/spring-tool-2.5.xsd) result 200). * [ ] http://www.springframework.org/schema/tool/spring-tool-3.1.xsd with 2 occurrences migrated to: https://www.springframework.org/schema/tool/spring-tool-3.1.xsd ([https](https://www.springframework.org/schema/tool/spring-tool-3.1.xsd) result 200). * [ ] http://www.w3.org/TR/2003/WD-DOM-Level-3-Events-20030331/ecma-script-binding.html with 1 occurrences migrated to: https://www.w3.org/TR/2003/WD-DOM-Level-3-Events-20030331/ecma-script-binding.html ([https](https://www.w3.org/TR/2003/WD-DOM-Level-3-Events-20030331/ecma-script-binding.html) result 200). * [ ] http://www.w3.org/TR/2011/REC-css3-selectors-20110929/ with 2 occurrences migrated to: https://www.w3.org/TR/2011/REC-css3-selectors-20110929/ ([https](https://www.w3.org/TR/2011/REC-css3-selectors-20110929/) result 200). * [ ] http://www.w3.org/TR/CSS21/syndata.html with 2 occurrences migrated to: https://www.w3.org/TR/CSS21/syndata.html ([https](https://www.w3.org/TR/CSS21/syndata.html) result 200). * [ ] http://www.w3.org/TR/selectors/ with 4 occurrences migrated to: https://www.w3.org/TR/selectors/ ([https](https://www.w3.org/TR/selectors/) result 200). * [ ] http://contributor-covenant.org with 1 occurrences migrated to: https://contributor-covenant.org ([https](https://contributor-covenant.org) result 301). * [ ] http://contributor-covenant.org/version/1/3/0/ with 1 occurrences migrated to: https://contributor-covenant.org/version/1/3/0/ ([https](https://contributor-covenant.org/version/1/3/0/) result 301). * [ ] http://dev.w3.org/csswg/cssom/ with 1 occurrences migrated to: https://dev.w3.org/csswg/cssom/ ([https](https://dev.w3.org/csswg/cssom/) result 301). * [ ] http://docs.python.org/library/functions.html with 1 occurrences migrated to: https://docs.python.org/library/functions.html ([https](https://docs.python.org/library/functions.html) result 301). * [ ] http://docs.spring.io/spring-batch/ with 1 occurrences migrated to: https://docs.spring.io/spring-batch/ ([https](https://docs.spring.io/spring-batch/) result 301). * [ ] http://docs.spring.io/spring-batch/apidocs/org/springframework/batch/core/launch/JobOperator.html with 1 occurrences migrated to: https://docs.spring.io/spring-batch/apidocs/org/springframework/batch/core/launch/JobOperator.html ([https](https://docs.spring.io/spring-batch/apidocs/org/springframework/batch/core/launch/JobOperator.html) result 301). * [ ] http://docs.spring.io/spring-batch/apidocs/org/springframework/batch/test/MetaDataInstanceFactory.html with 1 occurrences migrated to: https://docs.spring.io/spring-batch/apidocs/org/springframework/batch/test/MetaDataInstanceFactory.html ([https](https://docs.spring.io/spring-batch/apidocs/org/springframework/batch/test/MetaDataInstanceFactory.html) result 301). * [ ] http://docs.spring.io/spring-batch/reference/html/ with 1 occurrences migrated to: https://docs.spring.io/spring-batch/reference/html/ ([https](https://docs.spring.io/spring-batch/reference/html/) result 301). * [ ] http://docs.spring.io/spring-batch/reference/html/scalability.html with 1 occurrences migrated to: https://docs.spring.io/spring-batch/reference/html/scalability.html ([https](https://docs.spring.io/spring-batch/reference/html/scalability.html) result 301). * [ ] http://forum.spring.io/forum/spring-projects/batch with 2 occurrences migrated to: https://forum.spring.io/forum/spring-projects/batch ([https](https://forum.spring.io/forum/spring-projects/batch) result 301). * [ ] http://help.github.com/fork-a-repo/ with 2 occurrences migrated to: https://help.github.com/fork-a-repo/ ([https](https://help.github.com/fork-a-repo/) result 301). * [ ] http://help.github.com/forking/ with 1 occurrences migrated to: https://help.github.com/forking/ ([https](https://help.github.com/forking/) result 301). * [ ] http://help.github.com/send-pull-requests/ with 2 occurrences migrated to: https://help.github.com/send-pull-requests/ ([https](https://help.github.com/send-pull-requests/) result 301). * [ ] http://helpful.knobs-dials.com/index.php/Component_returned_failure_code:_0x80040111_ with 1 occurrences migrated to: https://helpful.knobs-dials.com/index.php/Component_returned_failure_code:_0x80040111_ ([https](https://helpful.knobs-dials.com/index.php/Component_returned_failure_code:_0x80040111_) result 301). * [ ] http://jquery.org/license with 2 occurrences migrated to: https://jquery.org/license ([https](https://jquery.org/license) result 301). * [ ] http://www.eaipatterns.com/toc.html (302) with 1 occurrences migrated to: https://www.enterpriseintegrationpatterns.com/toc.html ([https](https://www.eaipatterns.com/toc.html) result 301). * [ ] http://www.spring.io with 1 occurrences migrated to: https://www.spring.io ([https](https://www.spring.io) result 301). * [ ] http://www.spring.io/ with 2 occurrences migrated to: https://www.spring.io/ ([https](https://www.spring.io/) result 301). * [ ] http://www.w3.org/Addressing/URL with 1 occurrences migrated to: https://www.w3.org/Addressing/URL ([https](https://www.w3.org/Addressing/URL) result 301). * [ ] http://www.w3.org/TR/css3-selectors/ with 2 occurrences migrated to: https://www.w3.org/TR/css3-selectors/ ([https](https://www.w3.org/TR/css3-selectors/) result 301). * [ ] http://www.w3.org/TR/css3-syntax/ with 1 occurrences migrated to: https://www.w3.org/TR/css3-syntax/ ([https](https://www.w3.org/TR/css3-syntax/) result 301). * [ ] http://msdn.microsoft.com/en-us/library/ms536429%28VS.85%29.aspx with 2 occurrences migrated to: https://msdn.microsoft.com/en-us/library/ms536429%28VS.85%29.aspx ([https](https://msdn.microsoft.com/en-us/library/ms536429%28VS.85%29.aspx) result 302). * [ ] http://sourceforge.net/projects/cglib/files/cglib3/3.0/cglib-3.0.jar/download with 1 occurrences migrated to: https://sourceforge.net/projects/cglib/files/cglib3/3.0/cglib-3.0.jar/download ([https](https://sourceforge.net/projects/cglib/files/cglib3/3.0/cglib-3.0.jar/download) result 302). * [ ] http://spring.io/tools/sts/ with 1 occurrences migrated to: https://spring.io/tools/sts/ ([https](https://spring.io/tools/sts/) result 302). * [ ] http://stackoverflow.com/a/20002493/2910265 with 1 occurrences migrated to: https://stackoverflow.com/a/20002493/2910265 ([https](https://stackoverflow.com/a/20002493/2910265) result 302). * [ ] http://weblogs.java.net/blog/driscoll/archive/2009/09/08/eval-javascript-global-context with 1 occurrences migrated to: https://weblogs.java.net/blog/driscoll/archive/2009/09/08/eval-javascript-global-context ([https](https://weblogs.java.net/blog/driscoll/archive/2009/09/08/eval-javascript-global-context) result 302). * [ ] http://www.springsource.org/download with 1 occurrences migrated to: https://www.springsource.org/download ([https](https://www.springsource.org/download) result 302). # Ignored These URLs were intentionally ignored. * http://test with 2 occurrences * http://www.springframework.org/schema/batch with 15 occurrences * http://www.springframework.org/schema/batch-integration with 8 occurrences * http://www.springframework.org/schema/batch/test with 2 occurrences * http://www.springframework.org/schema/beans with 26 occurrences * http://www.springframework.org/schema/integration with 6 occurrences * http://www.springframework.org/schema/tool with 15 occurrences * http://www.w3.org/1999/XSL/Format with 4 occurrences * http://www.w3.org/1999/XSL/Transform with 3 occurrences * http://www.w3.org/2001/XMLSchema with 10 occurrences * http://www.w3.org/2001/XMLSchema-instance with 12 occurrences * http://xmlns.jcp.org/xml/ns/javaee with 8 occurrences
(cherry picked from commit a9fc6be)
Resolves BATCH-2782 (cherry picked from commit 30365ed)
Resolves BATCH-2802 (cherry picked from commit b497823)
According to the Javadoc of LineTokenizer#tokenize, the parameter `line` can be null. This commit adds `@Nullable` to that parameter. Resolves BATCH-2776 (cherry picked from commit 0d6a989)
fmbenhassine
added
in: infrastructure
status: waiting-for-triage
| * @param clazz The class of return type | ||
| * @param defaultValue Default value in case element is not present | ||
| * @param <V> Type of returned value | ||
| * @return The value of given type represented by the given key or {@code null} if the key |
There was a problem hiding this comment.
I believe this should be "or default value" instead of "or {@code null}". I will fix it on merge.
| if (value == null) { | ||
| return defaultValue; | ||
| } | ||
| return clazz.cast(value); |
There was a problem hiding this comment.
We need to check if the value is of the given type before the cast here, similar to what is done in readAndValidate. I will add this check.
fmbenhassine
pushed a commit
that referenced
this pull request
Sep 15, 2023
fmbenhassine
added a commit
that referenced
this pull request
Sep 15, 2023
- Rename variables - Update javadoc - Add type check before cast - Update code formatting
fmbenhassine
removed
the
status: waiting-for-triage
fmbenhassine
changed the title
Solodye
added a commit
to Solodye/spring-batch
that referenced
this pull request
Sep 24, 2024
Solodye
added a commit
to Solodye/spring-batch
that referenced
this pull request
Sep 24, 2024
Solodye
added a commit
to Solodye/spring-batch
that referenced
this pull request
Sep 24, 2024
Solodye
added a commit
to Solodye/spring-batch
that referenced
this pull request
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.