BATCH-1783: Forcing step termination when ChunkListener fails #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. Any chance you can squash these changes into a single commit and rebase to the main master? |
|
No problem. All squashed now. |
…ionException to force step termination
dsyer
added a commit
that referenced
this pull request
Oct 19, 2011
BATCH-1783: Forcing step termination when ChunkListener fails
garyrussell
pushed a commit
to garyrussell/spring-batch
that referenced
this pull request
Jan 7, 2014
* BATCHADM-167: BATCHADM-167: Updated parent pom to 2.2.0.RELEASE
This was referenced Dec 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting the ChunkListener to participate in retries and skips proved difficult as the context for retry and skips were not easily available. It can probably be done, but will require more extensive re-write of the step components. This change will at least fix the endless loop and the step will terminate if an exception is thrown in the ChunkListener (as is the default behavior for non-faulttolerant steps).