Skip to content
This repository has been archived by the owner on Feb 23, 2023. It is now read-only.

Move cloud-stream-kafka/rabbit samples to Spring AOT smoke tests #1690

Merged
merged 1 commit into from
Aug 19, 2022

Conversation

onobc
Copy link

@onobc onobc commented Aug 13, 2022

This proposal removes all cloud-stream-[kafka|rabbit] samples and leaves behind a README.md pointing to their new home.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Aug 13, 2022
@sdeleuze
Copy link
Contributor

I think the target is different (Spring Boot 2.x versus 3.x) so for now I think I would prefer to keep the samples on Spring Native side. Once Spring Boot 3 GA is released, I think we will do some global updates to Spring Native and its samples to redirect to Spring Boot 3, Spring AOT smoke tests and related documentation. As a consequence, I don't merge this PR. Feel free to let me know if that does not make sense from your POV.

@sdeleuze sdeleuze closed this Aug 19, 2022
@sdeleuze sdeleuze removed the status: waiting-for-triage An issue we've not yet triaged or decided on label Aug 19, 2022
@sdeleuze sdeleuze reopened this Aug 19, 2022
@sdeleuze
Copy link
Contributor

Sorry I miss it was on sb-3.0.x branch.

@sdeleuze sdeleuze merged commit fb691cc into spring-attic:sb-3.0.x Aug 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants