Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug when path contains directory with space #123

Merged
merged 1 commit into from
Jun 18, 2020

Conversation

aleksandergrzyb
Copy link
Contributor

What?

Uses fileURLWithPath instead of URLWithString.

Why?

For file system paths we should use fileURLWithPath:

Screenshot 2020-06-18 at 09 30 55

For example URLWithString fails if path contains Application Support directory.

@codecov
Copy link

codecov bot commented Jun 18, 2020

Codecov Report

Merging #123 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #123   +/-   ##
=======================================
  Coverage   98.43%   98.43%           
=======================================
  Files          14       14           
  Lines         960      960           
=======================================
  Hits          945      945           
  Misses         15       15           
Impacted Files Coverage Δ
Sources/SPTPersistentCache.m 98.26% <100.00%> (ø)
Sources/SPTPersistentCacheFileManager.m 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f4baa7...234c614. Read the comment docs.

@aleksandergrzyb aleksandergrzyb merged commit 8aaf1b6 into master Jun 18, 2020
@BalestraPatrick BalestraPatrick deleted the fix-bug-when-path-contains-space branch June 18, 2020 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants