Fix CI failures #374
Merged
Fix CI failures #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See oracle/truffleruby#1857 Also specify the version we test against, instead of having it change unexpectedly.
JRuby 9.1.17.0 and 9.2.6.0 failed on bundle install when they used Bundler 2.1.2.[1][2] Last green build[3] used Bundler 2.0.2. JRuby 9.2.7.0 and up works with Bundler 2.1.x[4]. Did not manage to remove Bundler 2.1.4 from Travis with just one "gem uninstall ..." command, don't know why. 1: https://travis-ci.org/sporkmonger/addressable/jobs/629762474 2: https://travis-ci.org/sporkmonger/addressable/jobs/629762473 3: https://travis-ci.org/sporkmonger/addressable/builds/583018677 4: https://travis-ci.org/dentarg/addressable/builds/633344956
houndci-bot
reviewed
Jan 7, 2020
|
|
||
| # Remove when truffleruby 19.3.1 is out, see | ||
| # https://github.com/oracle/truffleruby/issues/1857#issuecomment-567976167 | ||
| gem 'json', '~> 2.2.0' if RUBY_ENGINE == 'truffleruby' |
There was a problem hiding this comment.
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump Ruby versions
Fix JRuby CI failures
JRuby 9.1.17.0 and 9.2.6.0 failed on bundle install when they used
Bundler 2.1.2. Last green build used Bundler 2.0.2. JRuby
9.2.7.0 and up works with Bundler 2.1.x.
Did not manage to remove Bundler 2.1.4 from Travis with just one "gem
uninstall ..." command, don't know why.
Fix truffleruby CI failure
See rb_gc_register_mark_object not implemented in json 2.3.0 oracle/truffleruby#1857
Also specify the version we test against, instead of having it change
unexpectedly.