Update public suffix gem #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Jun 27, 2019
| gem 'rspec', '~> 3.5' | ||
| gem 'rspec-its', '~> 1.1' | ||
| gem 'rspec', '~> 3.8' | ||
| gem 'rspec-its', '~> 1.3' |
There was a problem hiding this comment.
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
| @@ -3,8 +3,8 @@ source 'https://rubygems.org' | |||
| gemspec | |||
|
|
|||
| group :test do | |||
| gem 'rspec', '~> 3.5' | |||
| gem 'rspec-its', '~> 1.1' | |||
| gem 'rspec', '~> 3.8' | |||
There was a problem hiding this comment.
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
tas50
reviewed
Jun 27, 2019
addressable.gemspec
Outdated
| s.add_development_dependency(%q<bundler>, ["< 3.0", ">= 1.0"]) | ||
| else | ||
| s.add_dependency(%q<public_suffix>, ["< 4.0", ">= 2.0.2"]) | ||
| s.add_dependency(%q<public_suffix>, ["< 4.1", ">= 2.0.2"]) |
There was a problem hiding this comment.
These should probably all just be < 5 since 4.x should be compatible with 4.0
There was a problem hiding this comment.
Agree! Changed 👍
|
I've pulled down the changes from this PR into my fork, applied some fixes from #349 and that made travis green again: https://travis-ci.com/dcermak/addressable/builds/122269862 and dcermak/addressable@master...6c2e7cc Can this then be merged after #349? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows to update
public_suffixgem to version 4.0.1.In addition, the warnings that appear when running the specs has been solved.