Make Exporter's preview a smoother experience #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PreviewUpdater was using QThreads to write the preview tables which made the Specification editor unresponsive especially when dealing with large number of tables. Also, it could deadlock when multiple threads accessed the same database via multiple DatabaseMappings (this is actually a spinedb_api issue). This replaces the QThreads by a single worker process. Because the tables are written in a separate process, we don't encounter Python's global interpreter lock. Re #2898
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #222 +/- ##
==========================================
+ Coverage 62.40% 62.43% +0.02%
==========================================
Files 168 168
Lines 17833 17864 +31
Branches 2981 2994 +13
==========================================
+ Hits 11129 11153 +24
- Misses 6098 6101 +3
- Partials 606 610 +4 ☔ View full report in Codecov by Sentry. |
soininen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes Exporter's Specification editor run much smoother while updating the preview tables. Since they do not freeze the UI anymore, previews are enable by default now. If we experience unresponsive UI again, we can change the default back to disabled.
Fixes spine-tools/Spine-Toolbox#2898
Checklist before merging