Fix changing Importer's mapping type #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Importer was using legacy functionality in spinedb_api to get blank mappings when user changes the mapping type. This does not work e.g. with Entity group mappings since those did not exist in pre-0.7 world. Re spine-tools/Spine-Toolbox#2662
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 0.8-dev #197 +/- ##
===========================================
+ Coverage 61.63% 61.68% +0.05%
===========================================
Files 190 190
Lines 17656 17656
Branches 2890 2890
===========================================
+ Hits 10882 10891 +9
+ Misses 6189 6183 -6
+ Partials 585 582 -3 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Importer was using legacy functionality in
spinedb_apito get blank mappings when user changed the mapping type. This did not work e.g. with Entity group mappings since those did not exist in pre-0.7 world.Fixes spine-tools/Spine-Toolbox#2662
spine-tools/Spine-Toolbox# (issue)
Checklist before merging