Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix db editor relationship incorrect filtering when object selected #2193

Merged
merged 1 commit into from
Jul 6, 2023

Conversation

PiispaH
Copy link
Collaborator

@PiispaH PiispaH commented Jul 6, 2023

Temporary fix for incorrect filtering

Fixes #2190

Checklist before merging

  • Documentation is up-to-date
  • Release notes have been updated
  • Unit tests have been added/updated accordingly
  • Code has been formatted by black
  • Unit tests pass

@codecov-commenter
Copy link

codecov-commenter commented Jul 6, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.10 🎉

Comparison is base (6325abe) 63.67% compared to head (e86028e) 63.77%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2193      +/-   ##
==========================================
+ Coverage   63.67%   63.77%   +0.10%     
==========================================
  Files         197      197              
  Lines       35786    35781       -5     
  Branches     6067     6065       -2     
==========================================
+ Hits        22787    22821      +34     
+ Misses      11788    11746      -42     
- Partials     1211     1214       +3     
Impacted Files Coverage Δ
...ine_db_editor/mvcmodels/single_parameter_models.py 66.66% <100.00%> (+0.78%) ⬆️

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@PiispaH PiispaH merged commit 65affa3 into master Jul 6, 2023
16 checks passed
@PiispaH PiispaH deleted the new_issue branch July 6, 2023 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Relationship parameter pane, treeview filtering by object not working correctly
2 participants